fix: error when using function in webpack output.publicPath

[roland-reed]

This PR contains a:

• bugfix
• new feature
• code refactor
• test update
• typo fix
• metadata update

Motivation / Use-Case

Fix #873

Breaking Changes

Additional Info

[linux-foundation-easycla]

• ❌ The commit (a85b970) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[linux-foundation-easycla]

• ❌ The commit (a85b970) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[alexander-akait]

It is invalid fix, because hash can be empty

[roland-reed]

Is this good to be merged? It seems that tests will not start until there's at least one approval

[alexander-akait]

Please read my answer

[roland-reed]

Sorry I read it wrong, I thought it was "valid" 😅. I have changed it to an arbitrary value since hash is not available, which came from the Webpack:

https://github.com/webpack/webpack/blob/main/lib/runtime/PublicPathRuntimeModule.js#L19-L27

[roland-reed]

Is it okay now? @alexander-akait

[codecov]

Codecov Report

Merging #874 (a89ae76) into master (e8c08a1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head a89ae76 differs from pull request most recent head a9edf9e. Consider uploading reports for the commit a9edf9e to get more accurate results

@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
+ Coverage   91.28%   91.30%   +0.02%     
==========================================
  Files           6        6              
  Lines         792      794       +2     
  Branches      214      215       +1     
==========================================
+ Hits          723      725       +2     
  Misses         63       63              
  Partials        6        6              

Impacted Files	Coverage Δ
src/loader.js	89.93% <100.00%> (+0.12%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8c08a1...a9edf9e. Read the comment docs.

[roland-reed]

Fixed a eslint issue, need another approve to run ci 😄 @alexander-akait

[roland-reed]

@alexander-akait Lint failed with 0 errors and 3 warnings, do warnings fail the lint? I checked that the 3 warnings are not introduced by this PR

[roland-reed]

@alexander-akait I found it's "lint:prettier" script failed, and I have fixed it. I found that pre-commit hook should format the changed file before commit, but in fact it failed to format the js files, is this behavior expected?

[roland-reed]

@alexander-akait hello, can this PR be merged? This fix is important for us.

[alexander-akait]

No, because it is invalid fix

[roland-reed]

No, because it is invalid fix

And the reason is?

[alexander-akait]

hash can't be xxxx

[alexander-akait]

Here fix #881, let's allow webpack to control public path, but yes, you are right, hash is xxxxx, because we are building modules and we don't know hash on this stage

[alexander-akait]

Anyway thanks for PR, let's close in favor my PR

[roland-reed]

It's okay, glad that you have fxied it