Skip to content
This repository was archived by the owner on Dec 5, 2019. It is now read-only.

test: added tests to ensure correct uglify-es version is being used. #69

Closed
wants to merge 1 commit into from

Conversation

hulkish
Copy link
Contributor

@hulkish hulkish commented Jul 6, 2017

@joshwiens
Copy link
Member

screen shot 2017-07-07 at 11 40 22 am

Attack of the modules .... again ! :p

@hulkish
Copy link
Contributor Author

hulkish commented Jul 7, 2017

Jeez, i guess i was incorrectly assuming the uglify-es version as the cause. what does this print out for u?

node -v
npm -v
cat node_modules/webpack/package.json | grep version
cat node_modules/uglify-es/package.json | grep version
cat node_modules/uglify-js/package.json | grep version

@joshwiens
Copy link
Member

screen shot 2017-07-07 at 12 05 17 pm

@hulkish
Copy link
Contributor Author

hulkish commented Jul 7, 2017

@d3viant0ne can u try installing npm >= 5? I suspect it's related to package-lock.json not being respected. Because we have [email protected] in our package-lock.json, but your version is printing 3.0.23

Another solution maybe we upgrade to [email protected]? Although... the npm version bump would still be needed.

@michael-ciniawsky
Copy link
Member

It sometimes works locally (macOS) for me, but the test are definitely flaky. But what is this test actually testing here ? 🙃

@hulkish
Copy link
Contributor Author

hulkish commented Jul 7, 2017

@michael-ciniawsky the test in this PR is not actually intended to be merged. Just an attempt to find the cause of this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants