-
-
Notifications
You must be signed in to change notification settings - Fork 380
Webpack dev server does not serve any assets #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Using |
Here's a more detailed breakdown (can elaborate): Broken state:A recent PR merge bumped our Webpack dev sever startup logs (scrubbed)
Webpack config (simplified)
Let me know if you need additional information. Also, I'm not really sure what caused the bump in |
package.json (scrubbed)
|
Thanks for your extended information. You're right in that a minor version bump should not break anything in theory, but in practice this can be very difficult. Any change can have unintended side effects, especially because so many people use this package in different ways. Two things:
|
Disclaimer: I'm still around. And I really appreciate your fast response(s)! I've been busy with a few other things for most of today. However, I will do both and report on any changes. One thing to add: I have another repo which just experienced the same thing. However, this other repo was not using a |
It has nothing to do with npm-shrinkwrap, but it has the advantage now that you can jump to specific webpack-dev-middleware versions, which helps in pinpointing the problem. |
Just encountered this issue while updating to
|
@razh, aha, thanks for the analysis. Would you mind doing a PR? Either way, please say so :). |
@SpaceK33z Sure, will do. |
Pass `true` for `slashesDenoteHost` in `url.parse`. https://nodejs.org/api/url.html#url_url_parse_urlstring_parsequerystring_slashesdenotehost Fixes webpack#128
Pass `true` for `slashesDenoteHost` in `url.parse`. https://nodejs.org/api/url.html#url_url_parse_urlstring_parsequerystring_slashesdenotehost Fixes #128
Just for historical purposes:
|
Awesome. Thanks! Also for historical purposes: here is a simple repo which reproduces the bug. Repo @ https://github.com/juanca/webpack-dev-middleware-404 |
I'll release a new version tomorrow, I'm busy atm. |
Published |
Environment details:
Most of our workstations are on node
6.3.0
and6.5.0
. And npm3.10.3
.Issue
Seems like a recent change in our
npm-shrinkwrap.json
broke the webpack-dev-server (seems like the server cannot find / server any bundle).We were able to figure out that bumping
webpack-dev-middleware
from1.6.1
to1.8.1
bricks the dev server. While pinning down the middle to1.6.1
unbricks the server.Is it normal to specify the
webpack-dev-middleware
dev dependency in ourpackage.json
? Should we try to avoid it to avoid any future headaches?Is this a known issue and is there an official fix?
Any help would be much appreciated.
Apologies if this is not the right channel to report this. I would appreciate a re-route / suggestions.
The text was updated successfully, but these errors were encountered: