Fix error handling in compiler watch()
and run()
#157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
Yes.
Summary
See #156. When the compiler wanted to report an error in the bundle (e.g. because of a plugin), it would throw the error and quit the process.
I've changed this to work more like the webpack watch mode; it shows the error with
console.error
but it keeps running (because the error can be fixed with a new compilation).Optionally, it's possible to hide / customize this error by using
options.error
.Does this PR introduce a breaking change?
Not really; previously the process would quit and now it doesn't.
Other information
Fixes #156