Skip to content

Webpack 4 #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2018
Merged

Webpack 4 #267

merged 2 commits into from
Feb 28, 2018

Conversation

shellscape
Copy link
Contributor

What kind of change does this PR introduce?

webpack version upgrade

Did you add tests for your changes?

Updated tests which needed attention.

Summary

Introduces full support for webpack v4 and removes support for lesser versions.
Upgrades several dependencies.

Does this PR introduce a breaking change?

Yes, webpack versions beneath v4 will not function with these changes.

Other information

This PR will be released as part of webpack-dev-middleware v3.

@codecov
Copy link

codecov bot commented Feb 28, 2018

Codecov Report

Merging #267 into master will decrease coverage by 0.71%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
- Coverage    97.9%   97.19%   -0.72%     
==========================================
  Files           5        6       +1     
  Lines         239      214      -25     
  Branches       72        0      -72     
==========================================
- Hits          234      208      -26     
- Misses          5        6       +1
Impacted Files Coverage Δ
lib/util.js 100% <100%> (ø) ⬆️
lib/context.js 95% <100%> (-3%) ⬇️
lib/DevMiddlewareError.js 100% <100%> (ø)
lib/middleware.js 94% <50%> (-0.12%) ⬇️
index.js 97.29% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d57c32...4731fd5. Read the comment docs.

@followbl
Copy link

y'all are awesomesauce...thanks 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants