Skip to content

Next #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 60 commits into from
Feb 13, 2020
Merged

Next #583

merged 60 commits into from
Feb 13, 2020

Conversation

alexander-akait
Copy link
Member

Merge next into master

hiroppy and others added 30 commits February 13, 2020 17:44
* refactor: rename lib to src

* refactor: use ESM

* chore(package.json): add prepublish task

* chore: rename lib to dist
BREAKING CHANGE: the `fs` option was renamed to the `outputFileSystem` option. The `fileSystem` property was removed from API, please use `context.outputFileSystem` instead. The middleware `locals` now under `res.locals.webpack` - use `res.locals.webpack.stats` for access stats and `res.locals.webpack.outputFileSystem` to access `fs`.
BREAKING CHANGE: the `reporter` option was removed without replacement
BRAKING CHANGE: the `webpackStats` property inside context was renamed to the `stats` property
BREAKING CHANGE: `logLevel`, `logTime` and `logger` options were removed without replacement. You can use the `infrastructurelog` (`infrastructureLog` in `webpack@5`) hook to customize logs. The `log` property in context was renamed to `logger`.
BREAKING CHANGE: drop koa support
BREAKING CHANGE: the `lazy` option was removed without replacement
* refactor: rename lib to src

* refactor: use ESM

* chore(package.json): add prepublish task

* chore: rename lib to dist
BREAKING CHANGE: the `fs` option was renamed to the `outputFileSystem` option. The `fileSystem` property was removed from API, please use `context.outputFileSystem` instead. The middleware `locals` now under `res.locals.webpack` - use `res.locals.webpack.stats` for access stats and `res.locals.webpack.outputFileSystem` to access `fs`.
BREAKING CHANGE: the `reporter` option was removed without replacement
BRAKING CHANGE: the `webpackStats` property inside context was renamed to the `stats` property
BREAKING CHANGE: `logLevel`, `logTime` and `logger` options were removed without replacement. You can use the `infrastructurelog` (`infrastructureLog` in `webpack@5`) hook to customize logs. The `log` property in context was renamed to `logger`.
evilebottnawi and others added 23 commits February 13, 2020 17:45
BREAKING CHANGE the `watchOptions` was removed, please setup `watchOptions` in webpack config https://webpack.js.org/configuration/watch/#watchoptions
BREAKING CHANGE: unwanted `charset=utf-8` not add to custom MIME types and MIME types which can be non utf-8. The `mimeTypes` option now accepts `extension` and `type` - `{ mimeTypes: { phtml: "text/html" } }`, the `force` option for the `mimeTypes` option was removed.
BREAKING CHANGE the `stats` was removed, please setup `stats` in webpack config https://webpack.js.org/configuration/stats/
BREAKING CHANGE: the `publicPath` respected from the "output.publicPath" configuration
BREAKING CHANGE: the `getFilenameFromUrl` method was removed from API
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #583 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #583   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files           8        8           
  Lines         228      228           
  Branches       71       71           
=======================================
  Hits          226      226           
  Misses          2        2           
Impacted Files Coverage Δ
src/utils/setupWriteToDisk.js 97.43% <0.00%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8073ba...b8073ba. Read the comment docs.

@alexander-akait alexander-akait merged commit 23a700a into master Feb 13, 2020
@alexander-akait alexander-akait deleted the next branch February 13, 2020 15:04
@Ekhrapykin
Copy link

Hi,
After merge get exception
`.../node_modules/webpack-dev-middleware/dist/utils/setupHooks.js:68
} else if (typeof statsOptions.colors === 'undefined' || typeof statsOptions === 'string') {
^

TypeError: Cannot read property 'colors' of undefined
at .../node_modules/webpack-dev-middleware/dist/utils/setupHooks.js:68:38
at processTicksAndRejections (internal/process/task_queues.js:79:11)
`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants