Skip to content

feat(client): move overlay option into client #2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Dec 1, 2020

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Move overlay option into client.

Breaking Changes

Yes

Additional Info

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #2888 (4013f77) into master (143ce32) will increase coverage by 0.16%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2888      +/-   ##
==========================================
+ Coverage   92.45%   92.61%   +0.16%     
==========================================
  Files          38       38              
  Lines        1246     1246              
  Branches      324      324              
==========================================
+ Hits         1152     1154       +2     
+ Misses         89       87       -2     
  Partials        5        5              
Impacted Files Coverage Δ
lib/Server.js 95.46% <50.00%> (ø)
client-src/clients/SockJSClient.js 65.90% <100.00%> (+4.54%) ⬆️
client-src/clients/WebsocketClient.js 58.13% <100.00%> (ø)
lib/servers/SockJSServer.js 94.11% <100.00%> (ø)
lib/servers/WebsocketServer.js 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cee170c...4013f77. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will put in my TODO - more e2e tests

@alexander-akait alexander-akait merged commit 763cde1 into master Dec 1, 2020
@alexander-akait alexander-akait deleted the feature/move-overlay-option branch December 1, 2020 10:48
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants