-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
refactor: rename describe property to description for cli-flags #2953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2953 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 37 37
Lines 1263 1263
Branches 328 328
=======================================
Hits 1167 1167
Misses 91 91
Partials 5 5 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this refactoring is not necessary /cc @alexander-akait
Actually, it's a TODO in |
@hiroppy we need fix it, because webpack (inside core) uses |
Yeah, I see but I didn't understand this context at first so please update the description. The current description of this PR is bad. |
Yeah, I should have used a better description. Updated 👍🏻 |
@alexander-akait can we remove this TODO https://github.com/webpack/webpack-cli/blob/4dc1a05046aeaf5a17de878a9e595697852bcd32/packages/webpack-cli/lib/webpack-cli.js#L139-L141 ? or we need to wait for a stable |
For Bugs and Features; did you add new tests?
no
Motivation / Use-Case
need use
description
instead ofdescribe
becausewebpack
andwebpack-cli
both usesdescription
property for options.This is helpful in the
webpack --help
output.https://github.com/webpack/webpack-cli/blob/4dc1a05046aeaf5a17de878a9e595697852bcd32/packages/webpack-cli/lib/webpack-cli.js#L139-L141
Breaking Changes
no
Additional Info
no