Skip to content

fix: content security policy issue in client log #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: content security policy issue in client log #3065

wants to merge 1 commit into from

Conversation

raix
Copy link
Contributor

@raix raix commented Mar 6, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Fix CSP issue client logger, idea for solving #3062

Breaking Changes

Additional Info

Done by stubbing out tapable SyncBailHook in client code

An idea for fixing #3062
@raix raix mentioned this pull request Mar 6, 2021
2 tasks
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution, let's unmark it from draft

@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #3065 (609a4fc) into master (e4fa1e7) will increase coverage by 1.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3065      +/-   ##
==========================================
+ Coverage   90.64%   92.22%   +1.58%     
==========================================
  Files          37       37              
  Lines        1261     1261              
  Branches      328      328              
==========================================
+ Hits         1143     1163      +20     
+ Misses        110       93      -17     
+ Partials        8        5       -3     
Impacted Files Coverage Δ
lib/Server.js 94.44% <0.00%> (-0.23%) ⬇️
lib/utils/routes.js 98.21% <0.00%> (+3.57%) ⬆️
lib/utils/DevServerPlugin.js 100.00% <0.00%> (+26.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4fa1e7...609a4fc. Read the comment docs.

@raix raix marked this pull request as ready for review March 6, 2021 20:11
@raix raix requested review from hiroppy and knagaitsev as code owners March 6, 2021 20:11
@snitin315
Copy link
Member

Rebased to #3078

@alexander-akait
Copy link
Member

Fixed, thanks for PR

@raix
Copy link
Contributor Author

raix commented Apr 1, 2021

Thanks for the merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants