Skip to content

test: add case for --history-api-fallback #3069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Mar 8, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

add test case for --history-api-fallback

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #3069 (e1efb8c) into master (e4fa1e7) will increase coverage by 1.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3069      +/-   ##
==========================================
+ Coverage   90.64%   92.30%   +1.66%     
==========================================
  Files          37       37              
  Lines        1261     1261              
  Branches      328      328              
==========================================
+ Hits         1143     1164      +21     
+ Misses        110       92      -18     
+ Partials        8        5       -3     
Impacted Files Coverage Δ
lib/utils/routes.js 98.21% <0.00%> (+3.57%) ⬆️
lib/utils/DevServerPlugin.js 100.00% <0.00%> (+26.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4fa1e7...e6c702d. Read the comment docs.

@snitin315 snitin315 merged commit 09eab84 into master Mar 8, 2021
@snitin315 snitin315 deleted the test/history-api-fallback branch March 8, 2021 13:43
@anshumanv
Copy link
Member

Point of CLI tests when webpack-cli will be used to invoke dev server?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants