Skip to content

test: update validation tests #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2021
Merged

test: update validation tests #3113

merged 1 commit into from
Mar 26, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

Update tests, injectHot was moved to client.needClientEntry

Breaking Changes

No

Additional Info

No

name: 'invalid `injectHot` configuration',
config: { injectHot: 1 },
name: 'invalid `needClientEntry` configuration',
config: { client: { needClientEntry: 1 } },
Copy link
Member

@alexander-akait alexander-akait Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #3113 (92d4d9d) into master (f139812) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3113   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files          37       37           
  Lines        1287     1287           
  Branches      346      346           
=======================================
  Hits         1181     1181           
  Misses        100      100           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f139812...92d4d9d. Read the comment docs.

@snitin315 snitin315 merged commit a6eb1a4 into master Mar 26, 2021
@snitin315 snitin315 deleted the validation branch March 26, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants