Skip to content

chore: ask for webpack-cli version in issue template #3305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2021
Merged

chore: ask for webpack-cli version in issue template #3305

merged 2 commits into from
May 17, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented May 17, 2021 •
edited
Loading

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Ask for webpack-cli version.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented May 17, 2021 •
edited
Loading

Codecov Report

Merging #3305 (04ff735) into master (9801377) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3305   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files          34       34           
  Lines        1260     1260           
  Branches      357      357           
=======================================
  Hits         1204     1204           
  Misses         52       52           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9801377...04ff735. Read the comment docs.

anshumanv
anshumanv reviewed May 17, 2021
View reviewed changes
Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think webpack@serve is relevant too?

rishabh3112
rishabh3112 requested changes May 17, 2021
View reviewed changes
Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion.

@snitin315 snitin315 force-pushed the snitin315-patch-1 branch from 2cae5e6 to 04ff735 Compare May 17, 2021 10:39
anshumanv
anshumanv approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicenicenice

@rishabh3112 rishabh3112 merged commit 88468b6 into master May 17, 2021
@rishabh3112 rishabh3112 deleted the snitin315-patch-1 branch May 17, 2021 11:37
@rishabh3112
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh3112 rishabh3112 rishabh3112 approved these changes

@anshumanv anshumanv anshumanv approved these changes

@alexander-akait alexander-akait Awaiting requested review from alexander-akait alexander-akait is a code owner

@hiroppy hiroppy Awaiting requested review from hiroppy hiroppy is a code owner

@knagaitsev knagaitsev Awaiting requested review from knagaitsev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snitin315 @rishabh3112 @anshumanv