Skip to content

feat: add overlay console #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: add overlay console #3332

wants to merge 1 commit into from

Conversation

anshumanv
Copy link
Member

@anshumanv anshumanv commented May 23, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yet to

Motivation / Use-Case

Allow logging errors on console

Breaking Changes

no

Additional Info

fixes #3361

@codecov
Copy link

codecov bot commented May 23, 2021

Codecov Report

Merging #3332 (bf2b220) into master (257e2eb) will decrease coverage by 0.12%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3332      +/-   ##
==========================================
- Coverage   95.69%   95.57%   -0.13%     
==========================================
  Files          34       34              
  Lines        1279     1289      +10     
  Branches      368      376       +8     
==========================================
+ Hits         1224     1232       +8     
- Misses         51       53       +2     
  Partials        4        4              
Impacted Files Coverage Δ
client-src/index.js 89.65% <80.00%> (-0.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 257e2eb...bf2b220. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should show errors/warnings from console (dev tools) in overlay

@alexander-akait
Copy link
Member

Let's close, because it is invalid fix and stale

@alexander-akait alexander-akait deleted the overlay branch October 5, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critial Dependency: the request of a dependency is an expression when upgrading to 4.0.0-beta.3 from beta.2
2 participants