Skip to content

Test warnings errors #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2021
Merged

Test warnings errors #3441

merged 4 commits into from
Jun 17, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

Output warnings and errors together, also fix logging for internal webpack logger + e2e tests

Breaking Changes

No

Additional Info

Better output all errors and warnings instead only one

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #3441 (8e9a635) into master (809631c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8e9a635 differs from pull request most recent head 5c8166d. Consider uploading reports for the commit 5c8166d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3441   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files          34       34           
  Lines        1358     1360    +2     
  Branches      401      403    +2     
=======================================
+ Hits         1287     1289    +2     
  Misses         66       66           
  Partials        5        5           
Impacted Files Coverage Δ
client-src/index.js 91.15% <100.00%> (+0.07%) ⬆️
lib/Server.js 94.84% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809631c...5c8166d. Read the comment docs.

@alexander-akait alexander-akait merged commit 5c8fa5b into master Jun 17, 2021
@alexander-akait alexander-akait deleted the test-warnings-errors branch June 17, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant