Skip to content

feat: add support to connect to unix socket #3457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

wip

Motivation / Use-Case

allows connecting to unix socket

Breaking Changes

shouldn't

Additional Info

WIP on more changes

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #3457 (b41dee1) into master (639cd75) will decrease coverage by 2.40%.
The diff coverage is 47.61%.

❗ Current head b41dee1 differs from pull request most recent head 49861f7. Consider uploading reports for the commit 49861f7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3457      +/-   ##
==========================================
- Coverage   94.77%   92.37%   -2.41%     
==========================================
  Files          34       33       -1     
  Lines        1360     1325      -35     
  Branches      403      409       +6     
==========================================
- Hits         1289     1224      -65     
- Misses         66       89      +23     
- Partials        5       12       +7     
Impacted Files Coverage Δ
lib/Server.js 91.23% <43.58%> (-3.61%) ⬇️
lib/utils/normalizeOptions.js 98.44% <100.00%> (+0.06%) ⬆️
client-src/index.js 83.18% <0.00%> (-7.97%) ⬇️
lib/utils/DevServerPlugin.js 95.20% <0.00%> (-2.28%) ⬇️
client-src/overlay.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 639cd75...49861f7. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we need test, ideally e2e

@alexander-akait alexander-akait mentioned this pull request Jun 23, 2021
6 tasks
@anshumanv
Copy link
Member Author

Closing in favour of #3479

@anshumanv anshumanv closed this Jun 24, 2021
@snitin315 snitin315 deleted the unix-support branch June 24, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants