Skip to content

fix: webSocketURL path option #3466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2021
Merged

fix: webSocketURL path option #3466

merged 3 commits into from
Jun 21, 2021

Conversation

anshumanv
Copy link
Member

@anshumanv anshumanv commented Jun 21, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

existing

Motivation / Use-Case

stick to URL spec

Breaking Changes

shouldn't

Additional Info

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #3466 (16990f2) into master (003c927) will increase coverage by 6.78%.
The diff coverage is 94.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3466      +/-   ##
==========================================
+ Coverage   87.45%   94.23%   +6.78%     
==========================================
  Files           9       33      +24     
  Lines         598     1302     +704     
  Branches      180      404     +224     
==========================================
+ Hits          523     1227     +704     
- Misses         63       68       +5     
+ Partials       12        7       -5     
Impacted Files Coverage Δ
lib/utils/findCacheDir.js 61.90% <61.90%> (ø)
client-src/index.js 83.18% <83.18%> (ø)
client-src/utils/sendMessage.js 85.71% <85.71%> (ø)
client-src/utils/reloadApp.js 86.95% <86.95%> (ø)
lib/utils/getCertificate.js 88.46% <88.46%> (ø)
lib/utils/getSocketServerImplementation.js 90.47% <90.47%> (ø)
lib/servers/SockJSServer.js 90.69% <90.69%> (ø)
lib/utils/setupExitSignals.js 90.90% <90.90%> (ø)
lib/Server.js 95.23% <95.86%> (+11.77%) ⬆️
client-src/utils/createSocketURL.js 96.42% <96.42%> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c3d69...16990f2. Read the comment docs.

@anshumanv
Copy link
Member Author

@alexander-akait CI green

@alexander-akait
Copy link
Member

I will merge after #3392

@alexander-akait alexander-akait merged commit fd63e02 into master Jun 21, 2021
@alexander-akait alexander-akait deleted the pathname branch June 21, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants