Skip to content

refactor: remove is-absolute-url in favor of method #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Avoid using dep for few lines of code.

Breaking Changes

None

Additional Info

No

@alexander-akait
Copy link
Member

Let's merge after this #3608 (I will finish today)

anshumanv
anshumanv previously approved these changes Aug 10, 2021
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #3609 (9a3ba6e) into master (974ce25) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3609   +/-   ##
=======================================
  Coverage   93.86%   93.87%           
=======================================
  Files          15       15           
  Lines        1287     1289    +2     
  Branches      442      443    +1     
=======================================
+ Hits         1208     1210    +2     
  Misses         72       72           
  Partials        7        7           
Impacted Files Coverage Δ
lib/Server.js 93.85% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 974ce25...9a3ba6e. Read the comment docs.

@alexander-akait alexander-akait dismissed stale reviews from anshumanv and themself via 9a3ba6e August 12, 2021 14:57
@alexander-akait alexander-akait merged commit 8fc0b03 into master Aug 12, 2021
@alexander-akait alexander-akait deleted the rm-is-abs-url branch August 12, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants