-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: enable magic HTML routes for module
output
#3773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.mjs
outputmodule
output
468974d
to
ed67b60
Compare
Codecov Report
@@ Coverage Diff @@
## master #3773 +/- ##
==========================================
- Coverage 92.78% 92.72% -0.07%
==========================================
Files 14 14
Lines 1345 1360 +15
Branches 467 470 +3
==========================================
+ Hits 1248 1261 +13
- Misses 90 92 +2
Partials 7 7
Continue to review full report at Codecov.
|
dfeaedd
to
48ce71d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add test for multi compiler mode?
48ce71d
to
279d677
Compare
Something wrong with Node 12 and MacOS, looking into it. |
f87803b
to
c269184
Compare
@snitin315 let's finish |
bded569
to
620ea64
Compare
It seems #3840 broke the magic HTML feature for multi-compiler mode. /cc @alexander-akait |
Can you provide example? |
- module.exports = setup({
+ module.exports = [setup({
context: __dirname,
entry: "./app.js",
devServer: {
magicHtml: true,
},
- });
+ })];
|
I think it is specific to this PR only, I am looking into it. |
620ea64
to
adab366
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test for publicPath
2ffba86
to
512a3d7
Compare
|
removed in v5 |
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
enable magic HTML routes for
.mjs
output.Breaking Changes
None
Additional Info
No