Skip to content

fix: remove process listeners after stopping the server #4013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2021
Merged

fix: remove process listeners after stopping the server #4013

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
447fe4d
fix: remove process listeners after stopping the server
snitin315 Nov 8, 2021
fcae3f5
fix: listener leak
alexander-akait Nov 12, 2021
3896404
test: fix
alexander-akait Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/Server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2258,6 +2258,11 @@ class Server {
this.middleware = null;
}
}

// We add listeners to signals when creating a new Server instance
// So ensure they are removed to prevent EventEmitter memory leak warnings
process.removeAllListeners("SIGINT");
process.removeAllListeners("SIGTERM");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not remove all of them just only our, move our close function above the file and use removeListener

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

above where?

Copy link
Member

@alexander-akait alexander-akait Nov 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere here https://github.com/webpack/webpack-dev-server/blob/master/lib/Server.js#L17, like

if (needForceShutdown) {
            exitProcess();
          }

          this.logger.info(
            "Gracefully shutting down. To force exit, press ^C again. Please wait..."
          );

          needForceShutdown = true;

          this.stopCallback(() => {
            if (typeof this.compiler.close === "function") {
              this.compiler.close(exitProcess);
            } else {
              exitProcess();
            }
});

from https://github.com/webpack/webpack-dev-server/blob/master/lib/Server.js#L1177

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I.e. just move it in function above the Server class and remove this listener in close

}

stopCallback(callback) {
Expand Down