Skip to content

fix:Compatible with onAfterSetupMiddleware #4141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2021
Merged

fix:Compatible with onAfterSetupMiddleware #4141

merged 1 commit into from
Dec 29, 2021

Conversation

godky
Copy link
Contributor

@godky godky commented Dec 29, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Breaking Changes

Additional Info

close #4140

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 29, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #4141 (b266660) into master (317e4b9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4141   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files          14       14           
  Lines        1543     1543           
  Branches      590      590           
=======================================
  Hits         1424     1424           
  Misses        110      110           
  Partials        9        9           
Impacted Files Coverage Δ
lib/Server.js 93.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 317e4b9...b266660. Read the comment docs.

@godky godky changed the title Compatible with onAfterSetupMiddleware fix:Compatible with onAfterSetupMiddleware Dec 29, 2021
Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but need to make CI is failing.
A test for this would be great as well.

@alexander-akait
Copy link
Member

We have failed CI not due this commit, I want to merge and restore CI in the other PR

@alexander-akait alexander-akait merged commit f6bc644 into webpack:master Dec 29, 2021
@godky godky deleted the onBeforeSetupMiddleware-patch-1 branch December 31, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatible with onAfterSetupMiddleware
3 participants