chore: update deps and types #4209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
force-pushed
the
update-chokidar
branch
from
51b760f to
64c42a6
Compare
lib/Server.js
Outdated
| @@ -754,7 +755,7 @@ class Server { | |||
| // TODO remove `{}` after drop webpack v4 support | |||
| const compilerWatchOptions = compilerOptions.watchOptions || {}; | |||
| /** | |||
| * @param {WatchOptions & WebpackConfiguration["watchOptions"]} watchOptions | |||
| * @param {WatchOptions & { aggregateTimeout?: number, ignored?: AnymatchMatcher | string | RegExp | string[], poll?: number | boolean }} watchOptions | |||
There was a problem hiding this comment.
Ideally we should extend type here, i.e. WebpackConfiguration["watchOptions"] & { ignored?: AnymatchMatcher | string | RegExp | string[] }
There was a problem hiding this comment.
I did that at first, but it was throwing lint errors with this.
snitin315
force-pushed
the
update-chokidar
branch
from
1574a53 to
0ae8729
Compare
Codecov Report
@@ Coverage Diff @@
## master #4209 +/- ##
=======================================
Coverage 92.47% 92.47%
=======================================
Files 14 14
Lines 1541 1541
Branches 590 590
=======================================
Hits 1425 1425
Misses 107 107
Partials 9 9
Continue to review full report at Codecov.
|
snitin315
requested review from
anshumanv,
hiroppy and
knagaitsev
as code owners
alexander-akait
approved these changes
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No
Motivation / Use-Case
update deps and types
Breaking Changes
None
Additional Info
No