Serve sockjs.js from sockjs-client dependency, don't use default from CDN #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sokra, could we get some movement on this? This issue makes the hotloader unusable. |
|
I don't exactly get why this should be in a separate bundle. |
|
@SpaceK33z I'm not sure if this is still the case but, at the time this pull request and issue #474 were opened, |
| @@ -52,7 +52,10 @@ | |||
| "ssl/" | |||
| ], | |||
| "scripts": { | |||
| "prepublish": "webpack ./client/live.js client/live.bundle.js --color --config client/webpack.config.js -p && webpack ./client/index.js client/index.bundle.js --color --config client/webpack.config.js -p", | |||
| "prepublish": "npm run webpack-live && npm run webpack-index && npm run webpack-sockjs", | |||
| "webpack-live": "webpack ./client/live.js client/live.bundle.js --color --config client/webpack.config.js -p", | |||
There was a problem hiding this comment.
Can you change webpack- to client- here (and the other scripts)? webpack doesn't tell me anything in this case.
SpaceK33z
added
Needs Response From Author
status: approved
and removed
X0: need more information
labels
SpaceK33z
requested changes
Sep 15, 2016
Volune
force-pushed
the
serve-sockjs-client
branch
from
590bbb2 to
9f1210e
Compare
SpaceK33z
approved these changes
Sep 16, 2016
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #474 "Incompatibile SockJS" (appears when using iframe mode)