Skip to content

refactor: use 'String#startsWith' & replace if-then-else #5501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

noritaka1166
Copy link
Contributor

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no

Motivation / Use-Case

  • Replace if-then-else flow by a single return statement
  • Use 'String#startsWith' method instead

Breaking Changes

no

Additional Info

no

Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.35%. Comparing base (af6bd68) to head (b21514c).
Report is 131 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5501      +/-   ##
==========================================
- Coverage   90.29%   83.35%   -6.95%     
==========================================
  Files          15       13       -2     
  Lines        1577     2025     +448     
  Branches      601      743     +142     
==========================================
+ Hits         1424     1688     +264     
- Misses        140      303     +163     
- Partials       13       34      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexander-akait alexander-akait merged commit 4367a5c into webpack:master May 21, 2025
52 of 53 checks passed
@noritaka1166 noritaka1166 deleted the refactor-server-js branch May 23, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants