Skip to content

Allow passing multiple hosts to 'public' #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

orteth01
Copy link
Contributor

What kind of change does this PR introduce?
bugfix

Did you add or update the examples/?
no

Summary
Host checking was added by default in v2.4.3 for security reasons. Users now have to specify the host/URL being used to access the dev-server more info here

This PR allows users to specify multiple hosts that that will pass the check. This will fix this person's issue

Does this PR introduce a breaking change?
no

@jsf-clabot
Copy link

jsf-clabot commented Apr 28, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 28, 2017

Codecov Report

Merging #896 into master will increase coverage by 0.29%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   73.62%   73.92%   +0.29%     
==========================================
  Files           4        4              
  Lines         436      441       +5     
  Branches      130      133       +3     
==========================================
+ Hits          321      326       +5     
  Misses        115      115
Impacted Files Coverage Δ
lib/Server.js 82.62% <75%> (-0.38%) ⬇️
lib/OptionsValidationError.js 60.86% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662bc31...179ed81. Read the comment docs.

@orteth01
Copy link
Contributor Author

orteth01 commented May 1, 2017

closing in favor of #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host checking breaks multi-host proxy
2 participants