Remove video/rtx codecs #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0nserv
force-pushed
the
fix/remove-rtx-codecs
branch
from
638a07d to
0517665
Compare
Codecov ReportBase: 56.53% // Head: 56.52% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #294 +/- ##
==========================================
- Coverage 56.53% 56.52% -0.01%
==========================================
Files 500 500
Lines 47446 47434 -12
Branches 12841 12841
==========================================
- Hits 26825 26814 -11
- Misses 9948 9949 +1
+ Partials 10673 10671 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
morajabi
approved these changes
Sep 19, 2022
We don't actually support handling RTX on a distinct SSRC and declaring these causes Chrome(and maybe others) to not sent retransmissions within the existing RTP stream. This all means that even if we emit NACKs the resulting retransmissions will simply be ignored.
k0nserv
force-pushed
the
fix/remove-rtx-codecs
branch
from
0517665 to
b1e22dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually support handling RTX on a distinct SSRC and declaring
these causes Chrome(and maybe others) to not sent retransmissions within
the existing RTP stream. This all means that even if we emit NACKs the
resulting retransmissions will simply be ignored.