根据优化建议修改 #6
Merged
根据优化建议修改 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.accept-type改为application/json 3.代码格式化
Closed
xy-peng
requested changes
Jul 16, 2022
There was a problem hiding this comment.
我不建议在方法声明加上对应的 exception：
- 所有的接口上都加上，跟没加一样
- RuntimeExcpetion 是不用加的
- 本来我们是希望开发者按需处理的
- 函数文档中有列出 throw 的
我们通过提供文档更“明显”让开发者知道会抛出异常，说明为什么我们使用 unchecked exception，结合常见的框架把最佳实践教给开发者的方式，让开发者做好错误处理？
@EmmetZC @Eric-Lee-Handyman 一起讨论下。
如果一定要列，我觉得根据继承关系，只列一个 WechatPayException ?
service/src/main/java/com/wechat/pay/java/service/payment/app/AppService.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/wechat/pay/java/core/http/OkHttpClientAdapterTest.java
Show resolved
Hide resolved
2.去掉Exception声明
xy-peng
requested changes
Jul 18, 2022
service/src/main/java/com/wechat/pay/java/service/payment/app/AppService.java
Outdated
Show resolved
Hide resolved
2.修改wechatPayCertificates判空方式
xy-peng
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.