Remote repo configuration #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 25, 2019 14:22
- Added dockerfile to deploy to remote repository
suharshan
force-pushed
the
remote-repo-configuration
branch
from
f988697 to
33e0893
Compare
suharshan
force-pushed
the
remote-repo-configuration
branch
from
94f01eb to
6fd3da9
Compare
suharshan
force-pushed
the
remote-repo-configuration
branch
from
f316091 to
268cb2a
Compare
suharshan
force-pushed
the
remote-repo-configuration
branch
3 times, most recently
from
f8a8e16 to
59526e7
Compare
suharshan
force-pushed
the
remote-repo-configuration
branch
2 times, most recently
from
1fac2dc to
7c53d33
Compare
suharshan
force-pushed
the
remote-repo-configuration
branch
from
29239a4 to
92c4c5a
Compare
added 3 commits
August 30, 2019 10:18
suharshan
force-pushed
the
remote-repo-configuration
branch
from
dd261a8 to
0129913
Compare
suharshan
force-pushed
the
remote-repo-configuration
branch
2 times, most recently
from
844ce71 to
b246b92
Compare
danielpoonwj
reviewed
Sep 6, 2019
Dockerfile
Outdated
| # Read repo args | ||
| ARG VERSION | ||
| ARG AWS_DEFAULT_REGION | ||
| ARG AWS_ACCESS_KEY_ID |
There was a problem hiding this comment.
are these args still needed? if they're being passed as runtime env vars can remove from here
There was a problem hiding this comment.
yeah forgot again. removed now
danielpoonwj
reviewed
Sep 7, 2019
Dockerfile
Outdated
| ENV REPO_URL=${REPO_URL} | ||
| ENV VERSION=${VERSION} | ||
| ENV AWS_DEFAULT_REGION=${AWS_DEFAULT_REGION} | ||
| ENV AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID} |
There was a problem hiding this comment.
don't need to assign here since its not available at build time
There was a problem hiding this comment.
Agree. Stripped down all unwanted args and envs.
danielpoonwj
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Approach
flattenplugin to make sure a flattened version of pom files are published to remote