Skip to content

Commit b996c80

Browse files
committed
Merge branch 'upstream/master' into rollup-index-improvement
* upstream/master: (100 commits) Avoid duplicate _type fields in v7 compat layer (elastic#83239) Bump bundled JDK to 17.0.2+8 (elastic#83243) [DOCS] Correct header syntax (elastic#83275) Add unit tests for indices.recovery.max_bytes_per_sec default values (elastic#83261) [DOCS] Add note that write indices are not replicated (elastic#82997) Add notes on indexing to kNN search guide (elastic#83188) Fix get-snapshot-api :docs:integTest (elastic#83273) FilterPathBasedFilter support match fieldname with dot (elastic#83178) Fix compilation issues in example-plugins (elastic#83258) fix ClusterStateListener javadoc (elastic#83246) Speed up Building Indices Lookup in Metadata (elastic#83241) Mute whole suite for elastic#82502 (elastic#83252) Make PeerFinder log messages happier (elastic#83222) [Docs] Add supported _terms_enum field types (elastic#83244) Add an aggregator for IPv4 and IPv6 subnets (elastic#82410) [CI] Fix 70_time_series/default sort yaml test failures (elastic#83217) Update test-failure Issue Template to include "needs:triage" label elastic#83226 Add an index->step cache to the PolicyStepsRegistry (elastic#82316) Improve support for joda datetime to java datetime transition in Painless (elastic#83099) Fix joda migration for week based methods in Painless (elastic#83232) ... # Conflicts: # x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/rollup/v2/TransportRollupAction.java
2 parents 531263c + 87ee045 commit b996c80

File tree

612 files changed

+14979
-4607
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

612 files changed

+14979
-4607
lines changed

.github/ISSUE_TEMPLATE/bug.md

Lines changed: 0 additions & 44 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/bug.yml

Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
name: Bug
2+
description: "Report a confirmed bug. For unconfirmed bugs please visit https://discuss.elastic.co/c/elasticsearch"
3+
labels: [">bug", "needs:triage"]
4+
body:
5+
- type: markdown
6+
attributes:
7+
value: |
8+
Github is reserved for bug reports and feature requests; it is
9+
not the place for general questions. If you have a question or
10+
an unconfirmed bug, please visit the [forums](https://discuss.elastic.co/c/elasticsearch).
11+
Please also check your OS is [supported](https://www.elastic.co/support/matrix#show_os).
12+
If it is not, the issue is likely to be closed.
13+
14+
For security vulnerabilities please only send reports to [email protected].
15+
See https://www.elastic.co/community/security for more information.
16+
17+
Please fill in the following details to help us reproduce the bug:
18+
- type: input
19+
id: es_version
20+
attributes:
21+
label: Elasticsearch Version
22+
description: The version of Elasticsearch you are running, found with `bin/elasticsearch --version`
23+
validations:
24+
required: true
25+
- type: input
26+
id: plugins
27+
attributes:
28+
label: Installed Plugins
29+
description: Comma separated list of plugins that you have installed
30+
validations:
31+
required: false
32+
- type: input
33+
id: java_version
34+
attributes:
35+
label: Java Version
36+
description: The version of Java Elasticsearch is running with, found with `java -version`
37+
value: _bundled_
38+
validations:
39+
required: true
40+
- type: input
41+
id: os_version
42+
attributes:
43+
label: OS Version
44+
description: The version of your operating system, found with `uname -a` of on unix-like system
45+
validations:
46+
required: true
47+
- type: textarea
48+
id: problem
49+
attributes:
50+
label: Problem Description
51+
description: A description of the problem including expected versus actual behavior
52+
validations:
53+
required: true
54+
- type: textarea
55+
id: steps
56+
attributes:
57+
label: Steps to Reproduce
58+
description: |
59+
A minimal but complete recreation of the problem including (e.g.) index
60+
creation, mappings, settings, query etc. The easier you make for us to
61+
reproduce it, the more likely that somebody will take the time to look at it.
62+
validations:
63+
required: true
64+
- type: textarea
65+
id: logs
66+
attributes:
67+
label: Logs (if relevant)
68+
description: Any log relevant log messages or snippets
69+
validations:
70+
required: false

.github/ISSUE_TEMPLATE/feature-request.md

Lines changed: 0 additions & 21 deletions
This file was deleted.
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
name: Feature Request
2+
description: Request a new feature we haven't thought of
3+
labels: [">enhancement", "needs:triage"]
4+
body:
5+
- type: markdown
6+
attributes:
7+
value: |
8+
Please first search existing issues for the feature you are requesting;
9+
it may already exist, even as a closed issue.
10+
- type: textarea
11+
id: description
12+
attributes:
13+
label: Description
14+
description: |
15+
Please give us as much context as possible about the feature. For example,
16+
you could include a story about a time when you wanted to use the feature,
17+
and also tell us what you had to do instead. The last part is helpful
18+
because it gives us an idea of how much harder your life is without the
19+
feature.

.github/ISSUE_TEMPLATE/test-failure.md

Lines changed: 0 additions & 28 deletions
This file was deleted.
Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
name: Test Failure
2+
description: A test failure in CI
3+
labels: [">test-failure","needs:triage"]
4+
body:
5+
- type: markdown
6+
attributes:
7+
value: Please fill out the following information, and ensure you have attempted to reproduce locally
8+
- type: input
9+
id: link
10+
attributes:
11+
label: CI Link
12+
description: A link to a Gradle buildscan (preferred) or Jenkins job with the failure
13+
validations:
14+
required: true
15+
- type: input
16+
id: repro_line
17+
attributes:
18+
label: Repro line
19+
description: The reproduce line from the build output
20+
validations:
21+
required: true
22+
- type: dropdown
23+
id: reproducible
24+
attributes:
25+
label: Does it reproduce?
26+
options:
27+
- "Yes"
28+
- "No"
29+
- "Didn't try"
30+
validations:
31+
required: true
32+
- type: input
33+
id: branches
34+
attributes:
35+
label: Applicable branches
36+
description: Branch names this failure has occurred on
37+
validations:
38+
required: true
39+
- type: input
40+
id: history
41+
attributes:
42+
label: Failure history
43+
description: Link to build stats and possible indication of when this started failing and how often
44+
validations:
45+
required: false
46+
- type: textarea
47+
id: excerpt
48+
attributes:
49+
label: Failure excerpt
50+
description: The error or exception that occurs
51+
validations:
52+
required: true

TESTING.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -556,7 +556,7 @@ version 5.3.2 run:
556556
./gradlew v5.3.2#bwcTest
557557
-------------------------------------------------
558558

559-
Use -Dtest.class and -Dtests.method to run a specific bwcTest test.
559+
Use -Dtests.class and -Dtests.method to run a specific bwcTest test.
560560
For example to run a specific tests from the x-pack rolling upgrade from 7.7.0:
561561
-------------------------------------------------
562562
./gradlew :x-pack:qa:rolling-upgrade:v7.7.0#bwcTest \

benchmarks/src/main/java/org/elasticsearch/benchmark/search/aggregations/AggConstructionContentionBenchmark.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@
2828
import org.elasticsearch.index.fielddata.IndexFieldData;
2929
import org.elasticsearch.index.fielddata.IndexFieldDataCache;
3030
import org.elasticsearch.index.mapper.MappedFieldType;
31+
import org.elasticsearch.index.mapper.NestedLookup;
3132
import org.elasticsearch.index.mapper.NumberFieldMapper;
3233
import org.elasticsearch.index.mapper.NumberFieldMapper.NumberType;
33-
import org.elasticsearch.index.mapper.ObjectMapper;
3434
import org.elasticsearch.index.query.QueryBuilder;
3535
import org.elasticsearch.index.query.support.NestedScope;
3636
import org.elasticsearch.indices.breaker.CircuitBreakerService;
@@ -277,7 +277,7 @@ public Optional<SortAndFormats> buildSort(List<SortBuilder<?>> sortBuilders) thr
277277
}
278278

279279
@Override
280-
public ObjectMapper getObjectMapper(String path) {
280+
public NestedLookup nestedLookup() {
281281
throw new UnsupportedOperationException();
282282
}
283283

benchmarks/src/main/java/org/elasticsearch/benchmark/search/fetch/subphase/FetchSourcePhaseBenchmark.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public void setup() throws IOException {
6666
);
6767
includesSet = Set.of(fetchContext.includes());
6868
excludesSet = Set.of(fetchContext.excludes());
69-
parserConfig = XContentParserConfiguration.EMPTY.withFiltering(includesSet, excludesSet);
69+
parserConfig = XContentParserConfiguration.EMPTY.withFiltering(includesSet, excludesSet, false);
7070
}
7171

7272
private BytesReference read300BytesExample() throws IOException {

benchmarks/src/main/java/org/elasticsearch/benchmark/xcontent/FilterContentBenchmark.java

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ public class FilterContentBenchmark {
6161
private BytesReference source;
6262
private XContentParserConfiguration parserConfig;
6363
private Set<String> filters;
64+
private XContentParserConfiguration parserConfigMatchDotsInFieldNames;
6465

6566
@Setup
6667
public void setup() throws IOException {
@@ -72,7 +73,8 @@ public void setup() throws IOException {
7273
};
7374
source = readSource(sourceFile);
7475
filters = buildFilters();
75-
parserConfig = buildParseConfig();
76+
parserConfig = buildParseConfig(false);
77+
parserConfigMatchDotsInFieldNames = buildParseConfig(true);
7678
}
7779

7880
private Set<String> buildFilters() {
@@ -105,9 +107,14 @@ public BytesReference filterWithParserConfigCreated() throws IOException {
105107
return filter(this.parserConfig);
106108
}
107109

110+
@Benchmark
111+
public BytesReference filterWithParserConfigCreatedMatchDotsInFieldNames() throws IOException {
112+
return filter(this.parserConfigMatchDotsInFieldNames);
113+
}
114+
108115
@Benchmark
109116
public BytesReference filterWithNewParserConfig() throws IOException {
110-
XContentParserConfiguration contentParserConfiguration = buildParseConfig();
117+
XContentParserConfiguration contentParserConfiguration = buildParseConfig(false);
111118
return filter(contentParserConfiguration);
112119
}
113120

@@ -152,7 +159,7 @@ public BytesReference filterWithBuilder() throws IOException {
152159
}
153160
}
154161

155-
private XContentParserConfiguration buildParseConfig() {
162+
private XContentParserConfiguration buildParseConfig(boolean matchDotsInFieldNames) {
156163
Set<String> includes;
157164
Set<String> excludes;
158165
if (inclusive) {
@@ -162,7 +169,7 @@ private XContentParserConfiguration buildParseConfig() {
162169
includes = null;
163170
excludes = filters;
164171
}
165-
return XContentParserConfiguration.EMPTY.withFiltering(includes, excludes);
172+
return XContentParserConfiguration.EMPTY.withFiltering(includes, excludes, matchDotsInFieldNames);
166173
}
167174

168175
private BytesReference filter(XContentParserConfiguration contentParserConfiguration) throws IOException {

build-tools-internal/build.gradle

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -202,14 +202,9 @@ configurations {
202202
integTestRuntimeOnly.extendsFrom(testRuntimeOnly)
203203
}
204204
dependencies {
205-
constraints {
206-
api("com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:${versions.getProperty('jackson')}") {
207-
version {
208-
strictly "${versions.getProperty('jackson')}"
209-
}
210-
because 'We want to use the exact same jackson version we use in production'
211-
}
212-
}
205+
components.all(JacksonAlignmentRule)
206+
// Forcefully downgrade the jackson platform as used in production
207+
api enforcedPlatform("com.fasterxml.jackson:jackson-bom:${versions.getProperty('jackson')}")
213208
api localGroovy()
214209
api gradleApi()
215210

@@ -230,7 +225,8 @@ dependencies {
230225
api 'de.thetaphi:forbiddenapis:3.2'
231226
api 'com.avast.gradle:gradle-docker-compose-plugin:0.14.13'
232227
api 'org.apache.maven:maven-model:3.6.2'
233-
api 'com.networknt:json-schema-validator:1.0.65'
228+
// needs to match the jackson minor version in use
229+
api 'com.networknt:json-schema-validator:1.0.49'
234230
api "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:${versions.getProperty('jackson')}"
235231
api 'org.ow2.asm:asm:9.2'
236232
api 'org.ow2.asm:asm-tree:9.2'
@@ -298,3 +294,14 @@ tasks.register("bootstrapPerformanceTests", Copy) {
298294
def root = file('..')
299295
filter(ReplaceTokens, tokens: [testGitCommit:GitInfo.gitInfo(root).revision])
300296
}
297+
298+
abstract class JacksonAlignmentRule implements ComponentMetadataRule {
299+
void execute(ComponentMetadataContext ctx) {
300+
ctx.details.with {d ->
301+
if (d.id.group.startsWith("com.fasterxml.jackson")) {
302+
// declare that Jackson modules all belong to the Jackson virtual platform
303+
belongsTo("com.fasterxml.jackson:jackson-bom:${d.id.version}")
304+
}
305+
}
306+
}
307+
}

0 commit comments

Comments
 (0)