FilterPathBasedFilter support match fieldname with dot #83178
Conversation
elasticsearchmachine
added
external-contributor
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
@elasticmachine, test this please |
There was a problem hiding this comment.
I think you've added two bits of my other PR that you should remove. I commented on the files. I think they are the right thing to change, but I want to get them reviewed by other folks. But I can review the xcontent change. I think it fine - though I'd prefer a non-recursive solution. I added a couple other test cases, one that blows up in a recursive solution.
I see now what you are doing with prefix matching - it's for if the pattern fully matches. That makes sense to me. I added some more test cases to the abstract filtering test case thingy for that too.
server/src/main/java/org/elasticsearch/cluster/routing/IndexRouting.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/cluster/routing/IndexRoutingTests.java
Outdated
Show resolved
Hide resolved
|
@nik9000 I've rollback the changes you comment and add some tests for double wildcard in |
|
@elasticmachine, test this please |
|
Thanks for your changes so far! I think one of the tests is still going to fail because the solution is recursive, but otherwise I'm happy with it. Could you try running |
|
I talked with @mushao999 about the recursion here. He mentioned that the test that I added actually stack overflows on other code! Ooops. But he's going to zap his recursion to make me happy. I'm thankful for that. |
|
@elasticmachine, test this please |
nik9000
added
the
auto-merge-without-approval
* upstream/master: (100 commits) Avoid duplicate _type fields in v7 compat layer (elastic#83239) Bump bundled JDK to 17.0.2+8 (elastic#83243) [DOCS] Correct header syntax (elastic#83275) Add unit tests for indices.recovery.max_bytes_per_sec default values (elastic#83261) [DOCS] Add note that write indices are not replicated (elastic#82997) Add notes on indexing to kNN search guide (elastic#83188) Fix get-snapshot-api :docs:integTest (elastic#83273) FilterPathBasedFilter support match fieldname with dot (elastic#83178) Fix compilation issues in example-plugins (elastic#83258) fix ClusterStateListener javadoc (elastic#83246) Speed up Building Indices Lookup in Metadata (elastic#83241) Mute whole suite for elastic#82502 (elastic#83252) Make PeerFinder log messages happier (elastic#83222) [Docs] Add supported _terms_enum field types (elastic#83244) Add an aggregator for IPv4 and IPv6 subnets (elastic#82410) [CI] Fix 70_time_series/default sort yaml test failures (elastic#83217) Update test-failure Issue Template to include "needs:triage" label elastic#83226 Add an index->step cache to the PolicyStepsRegistry (elastic#82316) Improve support for joda datetime to java datetime transition in Painless (elastic#83099) Fix joda migration for week based methods in Painless (elastic#83232) ... # Conflicts: # x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/rollup/v2/TransportRollupAction.java
Current
FilterPathBasedFilterdoes not support match fieldName with dot.This PR merges the changes of #83148 and #83152 together to add the ability of
matching fieldName with dotto theFilterPathBasedFilter.