Skip to content

[features] add pool crate feature #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2024
Merged

[features] add pool crate feature #188

merged 2 commits into from
Sep 18, 2024

Conversation

fakeshadow
Copy link
Contributor

Related discussion: #187

Copy link
Owner

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for opening this PR 👍

Just to confirm: You are mostly interested in having access to the PoolableConnection trait for your third party connection type, right?

@weiznich weiznich merged commit c8ee4a3 into weiznich:main Sep 18, 2024
38 checks passed
@fakeshadow
Copy link
Contributor Author

Looks good, thanks for opening this PR 👍

Just to confirm: You are mostly interested in having access to the PoolableConnection trait for your third party connection type, right?

Thanks for the quick review and merge.
Yes the PoolableConnection trait is essential for both my connection type and my pooling type. With it my connection type can use pooling feature from diesel-async like bb8 and deadpool. And at the same time my pooling type can use connection type from diesel-async as AsyncPgConnection and AsyncMySqlConnection.
Other public types and trait from pooled_connection are good to have for keeping a consistent api setup but they are not must keeping as public.

@fakeshadow fakeshadow deleted the pool branch September 18, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants