remove fields #123
Merged
remove fields #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhinof
suggested changes
Aug 15, 2019
gbus/worker.go
Outdated
| @@ -151,7 +151,7 @@ func (worker *worker) extractBusMessage(delivery amqp.Delivery) (*BusMessage, er | |||
| var decErr error | |||
| bm.Payload, decErr = worker.serializer.Decode(delivery.Body, bm.PayloadFQN) | |||
| if decErr != nil { | |||
| worker.log().WithError(decErr).WithField("message", delivery).Error("failed to decode message. rejected as poison") | |||
| worker.log().WithError(decErr).WithField("fqn", bm.PayloadFQN).Error("failed to decode message. rejected as poison") | |||
There was a problem hiding this comment.
we use message_name as the field name to log when logging this in other places so let's align on that
Suggested change
| worker.log().WithError(decErr).WithField("fqn", bm.PayloadFQN).Error("failed to decode message. rejected as poison") | |
| worker.log().WithError(decErr).WithField("meessage_name", bm.PayloadFQN).Error("failed to decode message. rejected as poison") |
ghost
requested a review
from
rhinof
approved these changes
Aug 15, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.