-
Notifications
You must be signed in to change notification settings - Fork 82
Explain the relationship between windows-1252, Latin1, and ASCII #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,14 @@ def create_table(): | |
if label_len > 1: | ||
rowspan = " rowspan=" + str(label_len) | ||
|
||
table += " <tr>\n <td" + rowspan + "><a>" + encoding["name"] + "</a>" | ||
if encoding["name"] != "windows-1252": | ||
table += " <tr><td" + rowspan + ">" + encoding["name"] + "\n" | ||
else: | ||
table += f""" <tr> | ||
<td{rowspan}> | ||
<a>{encoding["name"]}</a> | ||
<p class=note>See <a href="#note-latin1-ascii">below</a> for the relationship to historical | ||
"Latin1" and "ASCII" concepts.""" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suspect this is missing a newline at the end. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added one, and indeed the Python script output is more consistent now, but the main text doesn't match the Python script output: all the blank lines are omitted. Not sure what to do about that, if anything. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I took a more detailed look and pushed a fixup. Should be okay to land now from my perspective. |
||
i = 0 | ||
for label in encoding["labels"]: | ||
if i > 0: | ||
|
Uh oh!
There was an error while loading. Please reload this page.