Skip to content

Update to constructor operations #4870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Ms2ger opened this issue Aug 29, 2019 · 0 comments · Fixed by #4915
Closed

Update to constructor operations #4870

Ms2ger opened this issue Aug 29, 2019 · 0 comments · Fixed by #4915
Assignees
@domenic

Comments

@Ms2ger
Copy link
Member

Ms2ger commented Aug 29, 2019

See whatwg/webidl#778.
@domenic domenic self-assigned this Sep 17, 2019
domenic added a commit that referenced this issue Sep 17, 2019
@domenic
Update all constructors, including [HTMLConstructor]
25799f5 
This updates all the constructors in the standard for recent changes to
Web IDL. In particular:

* Replace [Constructor] extended attributes with constructor operations
* Cross-links constructor operations on events to the DOM event
  constructor definition
* Changes [HTMLConstructor] to apply to constructor operations, instead
  of to interfaces, and updates all usages of it
* Changes the definition of [HTMLConstructor] to leverage new Web IDL
  concepts of "usual constructor steps" and "internally create a new
  object implementing the interface"

Fixes #4870. Fixes #4890.
@domenic domenic mentioned this issue Sep 17, 2019
Merged
domenic added a commit that referenced this issue Sep 24, 2019
@domenic
Update all constructors, including [HTMLConstructor]
e38aa41 
This updates all the constructors in the standard for recent changes to
Web IDL. In particular:

* Replace [Constructor] extended attributes with constructor operations
* Cross-links constructor operations on events to the DOM event
  constructor definition
* Changes [HTMLConstructor] to apply to constructor operations, instead
  of to interfaces, and updates all usages of it
* Changes the definition of [HTMLConstructor] to leverage new Web IDL
  concepts of "usual constructor steps" and "internally create a new
  object implementing the interface"

Fixes #4870. Fixes #4890.
zcorpan pushed a commit that referenced this issue Nov 6, 2019
@domenic @zcorpan
Update all constructors, including [HTMLConstructor]
56f2e65 
This updates all the constructors in the standard for recent changes to
Web IDL. In particular:

* Replace [Constructor] extended attributes with constructor operations
* Cross-links constructor operations on events to the DOM event
  constructor definition
* Changes [HTMLConstructor] to apply to constructor operations, instead
  of to interfaces, and updates all usages of it
* Changes the definition of [HTMLConstructor] to leverage new Web IDL
  concepts of "usual constructor steps" and "internally create a new
  object implementing the interface"

Fixes #4870. Fixes #4890.
domenic pushed a commit that referenced this issue Nov 18, 2019
@TimvdLippe @domenic
Editorial: make the FormDataEvent constructor's argument required
c189722 
It already was, effectively, since it had a required member, but this is
more explicit.

Fixes #5064. Also fixes the constructor syntax per #4870.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domenic domenic

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update all constructors, including [HTMLConstructor] whatwg/html
2 participants
@Ms2ger @domenic