Change <menuitem> from void to like-<option> #907

zcorpan · 2016-03-21T15:38:22Z

Allow <menuitem> to have children giving the label

Change the content model
Change the processing to use trimmed child text content
(unlike <option> but matches Firefox)
Change label IDL attribute to match <option>

Fix #234: Change <menuitem> from void to like-<option>

Add menuitem to "Generate implied end tags"
<menuitem>, <hr> and <menu> pop a <menuitem>

cc @smaug---- @tkent-google

zcorpan · 2016-03-21T15:56:02Z

Should maybe remove menuitem from "Special"; #909

zcorpan · 2016-03-22T15:05:12Z

Need to add menuitem to the lists in "in body" An end-of-file token, An end tag whose tag name is "body" and An end tag whose tag name is "html", so that <!doctype html><menuitem> is not a parse error.

domenic · 2016-03-22T18:40:22Z

LGTM for what that's worth. Will leave it up to you when you feel comfortable merging.

zcorpan · 2016-03-22T19:06:11Z

Thanks! I want to finish writing some tests first, at least. The parser is tricky. If someone else also want to review, that would be appreciated. :-)

This tests whatwg/html#907.

zcorpan · 2016-03-23T14:54:11Z

Tests PR at html5lib/html5lib-tests#72

zcorpan · 2016-03-30T13:12:07Z

@hsivonen do you think you can you review this (and the tests)?

zcorpan · 2016-04-01T12:19:55Z

Since this PR makes <menu> close menuitem, the HealthKit page is still broken, it seems. Check http://software.hixie.ch/utilities/js/live-dom-viewer/saved/4028 in Firefox (I moved the </menuitem> tags to right before <menu>).

zcorpan · 2016-04-08T15:45:00Z

Given https://groups.google.com/a/chromium.org/d/msg/blink-dev/MkEDloT-yu8/miGAi4KpAgAJ I think we should land this.

domenic · 2016-04-08T15:46:03Z

Cool. Can you rebase? Then I will look for editorial issues and merge.

- Change the content model - Change the processing to use trimmed child text content (unlike <option> but matches Firefox) - Change label IDL attribute to match <option>

- Add menuitem to "Generate implied end tags" - <menuitem>, <hr> and <menu> pop a <menuitem> - <menuitem> is not void and is not "special" - An open menuitem at </body>, </html> or EOF is not a parse error.

zcorpan · 2016-04-08T16:00:35Z

Yep, rebased. (I'd prefer to have this merged as two commits to separate the parser changes.)

This tests whatwg/html#907.

sanjoypal · 2016-05-12T08:56:17Z

The specification says
"Allow menuitem to have endtag and menuitem element's end tag can be omitted if
the menuitem element is immediately followed by a menuitem, hr, or menu element,
or if there is no more content in the parent element."

"foo

bar"

What should be parser output for above html as "" is not immediately followed by "

" but a ""?

Hixie · 2016-05-12T16:00:40Z

The section you quoted is talking about conformance rules for writing HTML, and has nothing to do with how HTML is parsed. How HTML is parsed is discussed in the subsequent section.

sanjoypal · 2016-05-13T04:24:18Z

Can the menuitem element have menuitem/hr/menu as children? and this is what is done in https://developer.apple.com/library/ios/documentation/HealthKit/Reference/HealthKit_Constants/index.html#//apple_ref/c/econst/HKBodyTemperatureSensorLocationRectum, is the html in this page conforms this spec?

zcorpan · 2016-05-13T18:39:00Z

No, it cannot. That page is still broken with the spec change, see #907 (comment) above.

<menuitem><span>foo</span><menu>bar</menu></menuitem>

->

menuitem
- span
  - "foo"
menu
- "bar"

zcorpan · 2016-05-13T18:46:11Z

@hober can you help trying to get the Apple docs pages fixed (e.g. change from <menuitem> to <menu-item>)?

The current spec (2016.05.15) is missing the instruction to "reconstruct the active formatting elements" to match the handling of the <option> element See relevant discussions: whatwg/html#907 whatwg/html#234 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/MkEDloT-yu8 https://www.w3.org/Bugs/Public/show_bug.cgi?id=25325

sanjoypal · 2016-06-15T07:13:05Z

We are not able to ship "contextmenu" in blink because of apple site issue (https://developer.apple.com/library/ios/documentation/HealthKit/Reference/HealthKit_Constants/index.html#//apple_ref/c/econst/HKBodyTemperatureSensorLocationRectum). I filed a bug in apple bug tracker but no action is taken. Firefox does not comply with the spec in this case. So, Firefox does not break the apple site. Can the specification be modified to FF implementation?

hober · 2016-07-15T18:32:56Z

I can't reproduce this problem in the updated docs: https://developer.apple.com/reference/healthkit/hkbodytemperaturesensorlocation

zcorpan · 2016-07-16T17:18:58Z

Thank you @hober!

The old URL is still broken though. Do you think a redirect could be set up?

inikulin · 2016-08-04T11:34:00Z

source

+    <!-- fake </menuitem> (maybe) -->
+    <p>If the <span>current node</span> is a <code>menuitem</code> element, pop that node from the
+    <span>stack of open elements</span>.</p>
+    <!-- end of fake </menuitem> -->


Shouldn't it reconstruct active formatting element list like <option> do? This is how currently all implementations behaves, even tests landed by html5lib/html5lib-tests@88b8ee9 commit expect this.
\cc @zcorpan

Could you file an issue on that? @zcorpan is on vacation until August 9 so it's probably best to track that somewhere.

Sure

Update: #1627

Fallout from #907. Fixes #1627.

See whatwg/html#907 and whatwg/html#1638.

Fallout from whatwg#907. Fixes whatwg#1627.

zcorpan mentioned this pull request Mar 21, 2016

Parser: <option> not in the "Special" list #909

Closed

domenic added the normative change label Mar 22, 2016

zcorpan added the do not merge yet Pull request must not be merged per rationale in comment label Mar 22, 2016

zcorpan added a commit to zcorpan/html5lib-tests that referenced this pull request Mar 23, 2016

Add tests for non-void <menuitem>

807031b

This tests whatwg/html#907.

zcorpan mentioned this pull request Mar 23, 2016

Add tests for non-void <menuitem> html5lib/html5lib-tests#72

Merged

zcorpan removed the do not merge yet Pull request must not be merged per rationale in comment label Apr 8, 2016

zcorpan added 2 commits April 8, 2016 17:54

Allow <menuitem> to have children giving the label

8fdccb5

- Change the content model - Change the processing to use trimmed child text content (unlike <option> but matches Firefox) - Change label IDL attribute to match <option>

Fix #234: Change <menuitem> from void to like-<option>

5e49a20

- Add menuitem to "Generate implied end tags" - <menuitem>, <hr> and <menu> pop a <menuitem> - <menuitem> is not void and is not "special" - An open menuitem at </body>, </html> or EOF is not a parse error.

zcorpan force-pushed the menuitem-not-void branch from 99a93cf to 5e49a20 Compare April 8, 2016 15:59

domenic merged commit 5e49a20 into master Apr 8, 2016

domenic deleted the menuitem-not-void branch April 8, 2016 16:09

zcorpan added a commit to html5lib/html5lib-tests that referenced this pull request Apr 28, 2016

Add tests for non-void <menuitem> (#72)

88b8ee9

This tests whatwg/html#907.

zcorpan mentioned this pull request Jun 15, 2016

Parsing: <menuitem> should not be a void element #234

Closed

inikulin added a commit to inikulin/parse5 that referenced this pull request Aug 2, 2016

<menuitem> now behaves like <options> (see: whatwg/html#907)

f0180ec

inikulin reviewed Aug 4, 2016
View reviewed changes

inikulin mentioned this pull request Aug 4, 2016

<menuitem> start tag in <body> should reconstruct the list of active formatting elements #1627

Closed

zcorpan added a commit that referenced this pull request Aug 9, 2016

Reconstruct active formatting elements for <menuitem>

3592d27

Fallout from #907. Fixes #1627.

zcorpan mentioned this pull request Aug 9, 2016

Reconstruct active formatting elements for <menuitem> #1638

Merged

domenic pushed a commit that referenced this pull request Aug 10, 2016

Reconstruct active formatting elements for <menuitem>

2999aa0

Fallout from #907. Fixes #1627.

cscott added a commit to fgnass/domino that referenced this pull request Oct 18, 2016

<menuitem> is no longer void.

2c661ee

See whatwg/html#907 and whatwg/html#1638.

zcorpan mentioned this pull request Jan 31, 2017

Make <menuitem> parse like unknown elements #2308

Closed

mysticatea mentioned this pull request Jul 20, 2018

x-invalid-end-tag with iviewui component vuejs/eslint-plugin-vue#423

Closed

alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019

Reconstruct active formatting elements for <menuitem>

2d66ef8

Fallout from whatwg#907. Fixes whatwg#1627.

sundouzis pushed a commit to sundouzis/parse5 that referenced this pull request Sep 13, 2022

<menuitem> now behaves like <options> (see: whatwg/html#907)

5b79687

Change <menuitem> from void to like-<option> #907

Change <menuitem> from void to like-<option> #907

Uh oh!

Conversation

zcorpan commented Mar 21, 2016

Uh oh!

zcorpan commented Mar 21, 2016

Uh oh!

zcorpan commented Mar 22, 2016

Uh oh!

domenic commented Mar 22, 2016

Uh oh!

zcorpan commented Mar 22, 2016

Uh oh!

zcorpan commented Mar 23, 2016

Uh oh!

zcorpan commented Mar 30, 2016

Uh oh!

zcorpan commented Apr 1, 2016

Uh oh!

zcorpan commented Apr 8, 2016

Uh oh!

domenic commented Apr 8, 2016

Uh oh!

zcorpan commented Apr 8, 2016

Uh oh!

sanjoypal commented May 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Hixie commented May 12, 2016

Uh oh!

sanjoypal commented May 13, 2016

Uh oh!

zcorpan commented May 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zcorpan commented May 13, 2016

Uh oh!

sanjoypal commented Jun 15, 2016

Uh oh!

hober commented Jul 15, 2016

Uh oh!

zcorpan commented Jul 16, 2016

Uh oh!

inikulin Aug 4, 2016

Choose a reason for hiding this comment

Uh oh!

annevk Aug 4, 2016

Choose a reason for hiding this comment

Uh oh!

inikulin Aug 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sanjoypal commented May 12, 2016 •

edited

Loading

zcorpan commented May 13, 2016 •

edited

Loading

inikulin Aug 4, 2016 •

edited

Loading