Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bytes parsing when used with python-future #41

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

jameshilliard
Copy link
Contributor

This allows bencoder.pyx to be used with python-future, if the bytes type is enforced I get this error:

  File "bencoder.pyx", line 174, in bencoder.bencode
  File "bencoder.pyx", line 106, in bencoder.encode
  File "stringsource", line 67, in cfunc.to_py.__Pyx_CFunc_object____object____list___to_py.wrap
  File "bencoder.pyx", line 155, in bencoder.encode_dict
  File "bencoder.pyx", line 106, in bencoder.encode
  File "stringsource", line 67, in cfunc.to_py.__Pyx_CFunc_object____object____list___to_py.wrap
  File "bencoder.pyx", line 154, in bencoder.encode_dict
TypeError: Expected bytes, got newbytes

@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #41   +/-   ##
======================================
  Coverage    86.2%   86.2%           
======================================
  Files           1       1           
  Lines         116     116           
======================================
  Hits          100     100           
  Misses         16      16
Impacted Files Coverage Δ
bencoder.pyx 86.2% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e458f...992659a. Read the comment docs.

@whtsky whtsky merged commit d6d801d into whtsky:master Nov 15, 2018
@whtsky
Copy link
Owner

whtsky commented Nov 15, 2018

thanks

@whtsky
Copy link
Owner

whtsky commented Nov 15, 2018

released in v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants