Skip machine reconciliation for Paused clusters or machines #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hines - despite the predicates Signed-off-by: Ricardo Pardini <[email protected]>
rpardini
force-pushed
the
check-paused-cluster-and-or-machine-before-reconcilenormal
branch
from
0393518 to
dcb539e
Compare
|
|
Best (uneducated) guess why the already in-place predicates don't work: Those predicates got changed from annotation to spec field at some point, but the scvmmmachine doesn't have a .Spec.Paused field because it was never updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've still to demonstrate why the already in-place predicates fail to prevent it in the first place; my guess is because we can have Bootstrap-machines (clusterless) it ends up skipping too eagerly.