WIP: handful of minor things #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! All looks good to me. And more suggestions are welcome! Particularly if you have feedback on creating multiple Side question for my own education: is there a reason I don't think I've accepted changes to a PR on the branch. Should I just approve and then merge here?
|
williamhobbs
merged commit bd4f760
into
williamhobbs:nsrdb_goes_v4
1 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@williamhobbs thanks for this module! Here are a handful of minor things that I found as I was using it for PSM3 vs. 4 TMY comparisons. Feel free to directly fix on your branch. Consider this work in progress... I might have more suggestions as I use it more.