Skip to content

Upgrade @typescript-eslint/parser from ^5.6.0 to ^8.33.1 #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

wimpyprogrammer
Copy link
Owner

Include necessary fixes to Jest configuration.

Fixes generated by jules.

dependabot bot and others added 3 commits June 7, 2025 05:31
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.62.0 to 8.33.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.33.1/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-version: 8.33.1
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…t-eslint/parser.

The upgrade to version 8.33.1 of @typescript-eslint/parser introduced stricter linting rules, specifically regarding non-null assertions, which caused the build to fail.

Here's how I addressed the issue:
- I modified `packages/strings-to-regex/src/utils/trie.ts` to safely access an array element without using a non-null assertion. This resolved the `no-non-null-assertion` ESLint error.

Additionally, I noticed some `ts-jest` deprecation warnings during my work. I've also addressed those by:
- Updating `packages/strings-to-regex/jest.config.js` and `demo/jest.config.js` to move `ts-jest` configuration from `globals` to `transform` and removing the deprecated `isolatedModules` option.
- Adding `"isolatedModules": true` to `compilerOptions` in `packages/strings-to-regex/tsconfig.test.json` and `demo/tsconfig.test.json` as per `ts-jest` requirements.

The build now completes successfully, and everything is working as expected.
Do not pin dependencies with a lockfile since this is a library.  The project that depends on this library will ignore the lockfile and resolve its own versions.
@wimpyprogrammer wimpyprogrammer self-assigned this Jun 8, 2025
@wimpyprogrammer wimpyprogrammer added the dependencies Pull requests that update a dependency file label Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant