Skip to content
This repository was archived by the owner on Oct 11, 2022. It is now read-only.

Upgrade draft-js-plugin-no-console #2599

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Upgrade draft-js-plugin-no-console #2599

merged 1 commit into from
Mar 19, 2018

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Mar 19, 2018

Status

  • WIP
  • Ready for review
  • Needs testing

Fixes Danger

@mxstbr
Copy link
Contributor Author

mxstbr commented Mar 19, 2018

I'm admin merging this as it's blocking #2597

@mxstbr mxstbr merged commit 767d4f3 into alpha Mar 19, 2018
@mxstbr mxstbr deleted the fix-danger branch March 19, 2018 09:40
@spectrum-bot
Copy link

Fails
🚫

Danger failed to run dangerfile.js.

Error HttpError

{"message":"No commit found for the ref fix-danger","documentation_url":"https://developer.github.com/v3/repos/contents/"}
HttpError: {"message":"No commit found for the ref fix-danger","documentation_url":"https://developer.github.com/v3/repos/contents/"}
    at IncomingMessage.response.on (/home/circleci/spectrum/node_modules/@octokit/rest/lib/request/request.js:73:18)
    at emitNone (events.js:111:20)
    at IncomingMessage.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1064:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

Dangerfile

68| jest();
69| 
70| // Make sure nobody does a it.only and blocks our entire test-suite from running
71| noTestShortcuts({
72|   testFilePredicate: filePath => filePath.endsWith('.test.js'),
--------------------^
73| });
74| 
75| schedule(noConsole({ whitelist: ['error'] }));
76| 

Generated by 🚫 dangerJS

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants