Skip to content

FIX #835: null mNotification #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2022
Merged

Conversation

DanielEliraz
Copy link
Collaborator

In order to fix #835 we changed the clear operation to occur after the arguments' extraction.
also changed deprecated hasActiveCatalystInstance to hasActiveReactInstance

@DanielEliraz DanielEliraz merged commit 47161c9 into master Apr 24, 2022
@DanielEliraz DanielEliraz deleted the fix-835-null-mNotification branch April 24, 2022 13:28
@uzegonemad
Copy link

@DanielEliraz FYI this change causes compilation to fail when used in RN < 0.65.0 because hasActiveReactInstance() didn't exist before then. If possible, I'd suggest using a try/catch to fallback to the old method name for those who aren't able to upgrade to 0.65+ yet. Alternatively, noting that this requires RN >= 0.65.0 might be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android 11 and above crashing on notification open
2 participants