Messy error returns: Sometimes a string, sometimes an Error object #468

lll000111 · 2017-08-08T15:29:04Z

Looking at all reject() calls in https://github.com/wkh237/react-native-fetch-blob/blob/master/fs.js

Some have a string as argument, many others first do a new Error() around the string message (better - stacktrace is created).

Sometimes there is contradiction for the same error message:

Line 159

return Promise.reject(new Error('Invalid argument "path" '))

Line 172

return Promise.reject('Invalid argument "path" ')

RNFetchBlobWriteStream again uses strings for the reject-value in both its methods (write, close).

I would like to propose to use new Error(message) - always.

The text was updated successfully, but these errors were encountered:

* bump to 0.10.8 * Update PULL_REQUEST_TEMPLATE * Fix #468 "Messy error returns: Sometimes a string, sometimes an Error object" * Cleanup: remove an unused constant and duplicate method definitions * Cleanup: - fix minor errors in JSDoc comments, for example {string]} => {string} - fix parameter name "encode" => "encoding" (more logical, and it says so in the function's JSDoc too) - json-stream.js: split a looooong log message string constant into two parts and fix a typo ("maually"), and the type for objects is "Object" (capitalized) in Flow type annotations * Fix a (Flow) type conflict - fixes issue #461 * NEEDS REVIEW - Attempt to fix some of issue #460 (Error message normalization) Error messages reported by iOS and Android versions should be as similar as possible. Also, within the same system there should be consistency. This patch is an attempt to bring a LITTLE more of this consistency to the error messages. I also fixed some very few minor language issues, like "does not exist" (is the correct English). I tried keeping the changes to a minimum. Background: In my project code I want to know when a file already exists (e.g. after calling fs.createFile), and the only way is to check the error message string that I get. It's bad if they differ between versions (createFileASCII and createFile) and then also between Android and iOS version. At least some core part of the string should be the same, so that I have something to match. Ideally messages should come from a centralized easy (easier) to maintain file (for both iOS and Android), and ideally both systems should have the same errors and messages as far as possible.

* bump to 0.10.8 * Update PULL_REQUEST_TEMPLATE * Fix #468 "Messy error returns: Sometimes a string, sometimes an Error object" * Cleanup: remove an unused constant and duplicate method definitions * Cleanup: - fix minor errors in JSDoc comments, for example {string]} => {string} - fix parameter name "encode" => "encoding" (more logical, and it says so in the function's JSDoc too) - json-stream.js: split a looooong log message string constant into two parts and fix a typo ("maually"), and the type for objects is "Object" (capitalized) in Flow type annotations * Fix a (Flow) type conflict - fixes issue #461 * NEEDS REVIEW - Attempt to fix some of issue #460 (Error message normalization) Error messages reported by iOS and Android versions should be as similar as possible. Also, within the same system there should be consistency. This patch is an attempt to bring a LITTLE more of this consistency to the error messages. I also fixed some very few minor language issues, like "does not exist" (is the correct English). I tried keeping the changes to a minimum. Background: In my project code I want to know when a file already exists (e.g. after calling fs.createFile), and the only way is to check the error message string that I get. It's bad if they differ between versions (createFileASCII and createFile) and then also between Android and iOS version. At least some core part of the string should be the same, so that I have something to match. Ideally messages should come from a centralized easy (easier) to maintain file (for both iOS and Android), and ideally both systems should have the same errors and messages as far as possible. * Fixes #467 by improving the write() function of write streams: By resolving with the RNFetchBlobWriteStream instance instead of with "undefined" writes can now be chained: RNFetchBlob.fs.writeStream(PATH_TO_FILE, 'utf8', true) .then((ofstream) => ofstream.write('foo')) .then((ofstream) => ofstream.write('bar')) .then((ofstream) => ofstream.write('foobar')) .then((ofstream) => ofstream.close()) Reference: #467 (comment)

* upstream/0.10.9: Fixed problem with type casting (wkh237#513) My proposed 0.10.9 changes (wkh237#489) wkh237#268 Cancelled task should not trigger `then` promise function Add ability to cancel android DownloadManager fetches (wkh237#502) Fix iOS initialization race condition (wkh237#499) prevent UIApplication methods from being called on background thread (wkh237#486) Implemenet fs.hash() -- wkh237#439 "Feature: Calculate file hash" (wkh237#476) I forgot one error string for the Android readFile() method (wkh237#475) Fix for wkh237#467 (wkh237#472) Fix for issue wkh237#468, wkh237#461, wkh237#460 and minor cleanup (wkh237#469)

lll000111 mentioned this issue Aug 8, 2017

Fix for issue #468, #461, #460 and minor cleanup #469

Merged

lll000111 closed this as completed Aug 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Messy error returns: Sometimes a string, sometimes an Error object #468

Messy error returns: Sometimes a string, sometimes an Error object #468

lll000111 commented Aug 8, 2017 •

edited

Loading

Messy error returns: Sometimes a string, sometimes an Error object #468

Messy error returns: Sometimes a string, sometimes an Error object #468

Comments

lll000111 commented Aug 8, 2017 • edited Loading

lll000111 commented Aug 8, 2017 •

edited

Loading