This repository was archived by the owner on Jan 26, 2019. It is now read-only.
Fix travis build #302
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,7 +56,7 @@ | |
| "text-table": "0.2.0" | ||
| }, | ||
| "devDependencies": { | ||
| "jest": "22.4.2" | ||
| }, | ||
| "scripts": { | ||
| "test": "jest" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,13 +14,17 @@ cd "$(dirname "$0")" | |
|
|
||
| # CLI and app temporary locations | ||
| # http://unix.stackexchange.com/a/84980 | ||
| temp_app_path=`mktemp -d 2>/dev/null || mktemp -d -t 'temp_app_path'` | ||
| custom_registry_url=http://localhost:4873 | ||
| original_npm_registry_url=`npm get registry` | ||
| original_yarn_registry_url=`yarn config get registry` | ||
|
|
||
| function cleanup { | ||
| echo 'Cleaning up.' | ||
| cd "$root_path" | ||
| rm -rf "$temp_app_path" | ||
| npm set registry "$original_npm_registry_url" | ||
| yarn config set registry "$original_yarn_registry_url" | ||
| } | ||
|
|
||
| # Error messages are redirected to stderr | ||
|
|
@@ -55,10 +59,6 @@ function checkDependencies { | |
| fi | ||
| } | ||
|
|
||
| # Exit the script with a helpful error message when any error is encountered | ||
| trap 'set +x; handle_error $LINENO $BASH_COMMAND' ERR | ||
|
|
||
|
|
@@ -72,98 +72,82 @@ set -x | |
| cd .. | ||
| root_path=$PWD | ||
|
|
||
| if hash npm 2>/dev/null | ||
| then | ||
| npm i -g npm@latest | ||
| npm cache clean || npm cache verify | ||
| fi | ||
|
|
||
| # Bootstrap monorepo | ||
| yarn | ||
|
|
||
| # ****************************************************************************** | ||
| # First, publish the monorepo. | ||
| # ****************************************************************************** | ||
|
|
||
| # Start local registry | ||
| tmp_registry_log=`mktemp` | ||
| nohup npx [email protected] &>$tmp_registry_log & | ||
| # Wait for `verdaccio` to boot | ||
| grep -q 'http address' <(tail -f $tmp_registry_log) | ||
|
|
||
| # Set registry to local registry | ||
| npm set registry "$custom_registry_url" | ||
| yarn config set registry "$custom_registry_url" | ||
|
|
||
| # Login so we can publish packages | ||
| npx [email protected] -u user -p password -e [email protected] -r "$custom_registry_url" --quotes | ||
|
|
||
| # Publish the monorepo | ||
| git clean -df | ||
| ./tasks/publish.sh --yes --force-publish=* --skip-git --cd-version=prerelease --exact --npm-tag=latest | ||
|
|
||
| # ****************************************************************************** | ||
| # Test --scripts-version with a version number | ||
| # ****************************************************************************** | ||
|
|
||
| cd "$temp_app_path" | ||
| npx create-react-app --scripts-version=1.0.17 test-app-version-number | ||
|
There was a problem hiding this comment. I think There was a problem hiding this comment. This test suite is disabled for now. |
||
| cd test-app-version-number | ||
|
|
||
| # Check corresponding scripts version is installed. | ||
| exists node_modules/react-scripts | ||
| grep '"version": "1.0.17"' node_modules/react-scripts/package.json | ||
| checkDependencies | ||
|
|
||
| # ****************************************************************************** | ||
| # Test --use-npm flag | ||
| # ****************************************************************************** | ||
|
|
||
| cd "$temp_app_path" | ||
| npx create-react-app --use-npm --scripts-version=1.0.17 test-use-npm-flag | ||
|
|
||
| cd test-use-npm-flag | ||
|
|
||
| # Check corresponding scripts version is installed. | ||
| exists node_modules/react-scripts | ||
| [ ! -e "yarn.lock" ] && echo "yarn.lock correctly does not exist" | ||
| grep '"version": "1.0.17"' node_modules/react-scripts/package.json | ||
|
|
||
| checkDependencies | ||
|
|
||
| # ****************************************************************************** | ||
| # Test --scripts-version with a tarball url | ||
| # ****************************************************************************** | ||
|
|
||
| cd "$temp_app_path" | ||
| npx create-react-app --scripts-version=https://registry.npmjs.org/react-scripts/-/react-scripts-1.0.17.tgz test-app-tarball-url | ||
|
|
||
| cd test-app-tarball-url | ||
|
|
||
| # Check corresponding scripts version is installed. | ||
| exists node_modules/react-scripts | ||
| grep '"version": "1.0.17"' node_modules/react-scripts/package.json | ||
| checkDependencies | ||
|
|
||
| # ****************************************************************************** | ||
| # Test --scripts-version with a custom fork of react-scripts | ||
| # ****************************************************************************** | ||
|
|
||
| cd "$temp_app_path" | ||
| npx create-react-app --scripts-version=react-scripts-fork test-app-fork | ||
| cd test-app-fork | ||
|
|
||
| # Check corresponding scripts version is installed. | ||
|
|
@@ -175,7 +159,7 @@ exists node_modules/react-scripts-fork | |
|
|
||
| cd "$temp_app_path" | ||
| # we will install a non-existing package to simulate a failed installataion. | ||
| npx create-react-app --scripts-version=`date +%s` test-app-should-not-exist || true | ||
| # confirm that the project folder was deleted | ||
| test ! -d test-app-should-not-exist | ||
|
|
||
|
|
@@ -187,7 +171,7 @@ cd "$temp_app_path" | |
| mkdir test-app-should-remain | ||
| echo '## Hello' > ./test-app-should-remain/README.md | ||
| # we will install a non-existing package to simulate a failed installataion. | ||
| npx create-react-app --scripts-version=`date +%s` test-app-should-remain || true | ||
| # confirm the file exist | ||
| test -e test-app-should-remain/README.md | ||
| # confirm only README.md is the only file in the directory | ||
|
|
@@ -201,7 +185,7 @@ fi | |
|
|
||
| cd $temp_app_path | ||
| curl "https://registry.npmjs.org/@enoah_netzach/react-scripts/-/react-scripts-0.9.0.tgz" -o enoah-scripts-0.9.0.tgz | ||
| npx create-react-app --scripts-version=$temp_app_path/enoah-scripts-0.9.0.tgz test-app-scoped-fork-tgz | ||
| cd test-app-scoped-fork-tgz | ||
|
|
||
| # Check corresponding scripts version is installed. | ||
|
|
@@ -216,22 +200,22 @@ cd "$temp_app_path" | |
| mkdir test-app-nested-paths-t1 | ||
| cd test-app-nested-paths-t1 | ||
| mkdir -p test-app-nested-paths-t1/aa/bb/cc/dd | ||
| npx create-react-app test-app-nested-paths-t1/aa/bb/cc/dd | ||
| cd test-app-nested-paths-t1/aa/bb/cc/dd | ||
| yarn start --smoke-test | ||
|
|
||
| # Testing a path that does not exist | ||
| cd "$temp_app_path" | ||
| npx create-react-app test-app-nested-paths-t2/aa/bb/cc/dd | ||
| cd test-app-nested-paths-t2/aa/bb/cc/dd | ||
| yarn start --smoke-test | ||
|
|
||
| # Testing a path that is half exists | ||
| cd "$temp_app_path" | ||
| mkdir -p test-app-nested-paths-t3/aa | ||
| npx create-react-app test-app-nested-paths-t3/aa/bb/cc/dd | ||
| cd test-app-nested-paths-t3/aa/bb/cc/dd | ||
| yarn start --smoke-test | ||
|
|
||
| # Cleanup | ||
| cleanup | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just keep
e2e-simpleas the others test a lot of stuff fromcreate-react-appwe don't care about.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
installis disabled for now.