Skip to content

portalContainer missing in DatePickerProps interface #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
27-7survey opened this issue Apr 7, 2022 · 3 comments · Fixed by #412
Closed
2 tasks done

portalContainer missing in DatePickerProps interface #409

27-7survey opened this issue Apr 7, 2022 · 3 comments · Fixed by #412
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@27-7survey
Copy link

Before you start - checklist

  • I followed instructions in documentation written for my React-Date-Picker version
  • I have checked if this bug is not already reported

Description

In index.d.ts where is DatePickerProps interface definition portalContainer is missing

Steps to reproduce

not applicable

Expected behavior

not applicable

Actual behavior

not applicable

Additional information

No response

Environment

  • Browser (if applicable):
  • React-Date-Picker version:
  • React version:
@27-7survey 27-7survey added the bug Something isn't working label Apr 7, 2022
@27-7survey
Copy link
Author

As I see portalContainer is not available in latest version (8.4.0), but it is mentioned in README.md, so maybe it will be available in next release

@wojtekmaj wojtekmaj reopened this Apr 8, 2022
@wojtekmaj wojtekmaj added the help wanted Extra attention is needed label Apr 8, 2022
@MatteoGauthier
Copy link

Any news about this issue ?

mpham-r7 added a commit to mpham-r7/react-date-picker that referenced this issue May 19, 2022
@mpham-r7
add portalContainer to interface
652a0e6 
closes wojtekmaj#409
@mpham-r7 mpham-r7 mentioned this issue May 19, 2022
Merged
@mpham-r7
Copy link
Contributor

#412

wojtekmaj pushed a commit that referenced this issue May 20, 2022
@mpham-r7
Add portalContainer prop to TypeScript typings (#412)
1be6ea1 
Closes #409
wojtekmaj pushed a commit that referenced this issue May 20, 2022
@mpham-r7 @wojtekmaj
Add portalContainer prop to TypeScript typings (#412)
e1b95e3 
Closes #409
wojtekmaj pushed a commit that referenced this issue Sep 6, 2022
@mpham-r7 @wojtekmaj
Add portalContainer prop to TypeScript typings (#412)
52f008f 
Closes #409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add portalContainer prop to TypeScript typings mpham-r7/react-date-picker
4 participants
@wojtekmaj @mpham-r7 @MatteoGauthier @27-7survey