Fix traversal of CoreFn CaseAlternative Binders #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 5734b10 re-implemented the Purescript `everythingOnValues` function locally. While simplifying the function for the specific use-case vital functionality was left out for traversing CaseAlternatives. This commit re-introduces the removed functionality and adds a regression test.
|
The test failure is a result of re-exports remaining after DCE. This is fixed by #3 |
| onBinder b@(NamedBinder _ _ b1) = onBinder' b ++ onBinder b1 | ||
| onBinder b = onBinder' b | ||
|
|
||
| onBinder' :: Binder Ann -> [Key] |
There was a problem hiding this comment.
I'd love for this to have a more descriptive name.
There was a problem hiding this comment.
Yeah me too. Is it possible for you to pull in commits from MaybeJustJames/zephyr so I can clean up there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 5734b10 re-implemented the Purescript
everythingOnValuesfunction locally. While simplifying the function for the specific use-case vital functionality was left out for traversingCaseAlternatives. This commit re-introduces the removed functionality and adds a regression test.