[Bug] AutomationProperties on Button still visible on Android if Text Property is empty #7875

MathewLC · 2019-10-08T14:32:09Z

Description

This error is hapenning in the actual version of xamarin forms.

Basic Information

IDE: Visual Studio 2019
Platform Target Frameworks:
- Android: Android 10 (API Level 29)
Nuget Packages: Xamarin.Forms (4.2.0.848062)
Tested Devices: Emulators with Android 10 and 9. Nokia x6 with Android 9.

Screenshots

Reproduction Link

AppTeste.zip

jfversluis · 2019-10-08T15:08:23Z

Seems to happen indeed, only on Android. What I somehow suspect is that we somehow, somewhere assign this to a visible property whenever that is empty? Need to investigate a bit on that.

As a workaround you could enter a space in your Text property for now.

magoolation · 2019-10-08T16:33:30Z

I'd like to work om this as I'm focused on accessibility improvements on Xamarin.Forms

jfversluis · 2019-10-08T17:52:19Z

By all means, please go ahead! I'll assign it to me for now so no one will snatch it from you. If, for some reason, you can't finish it please let me know :)

MathewLC · 2019-10-09T13:08:26Z

If help you guys, I run into another issue related to this. It seems like the properties are only hide but definily is on the UI. In the sample I'll send, the same button with and without AutomationProperties, has different width value as you can see in the screenshot.

ScreenShot

Reproduction Link

AppTeste.zip

jfversluis · 2019-10-09T18:39:43Z

I'm not sure what you're trying to say. You mean using the AutomationProperties are impacting the width?

hartez · 2019-10-09T18:54:28Z

I'm not sure what you're trying to say. You mean using the AutomationProperties are impacting the width?

We had a problem like that last year; maybe this is a similar situation? #2580

MathewLC · 2019-10-09T18:54:40Z

Exactly. In the code that's in the sample I've sended, you can see that the two buttons that reproduce this images, are equals with the only difference being the automationproperties in the last one.

See the folling code:

        <!--This don't have extra width because don't have AutomationProperties --> 
        <Button Text="Tiny"
                VerticalOptions="CenterAndExpand"
                HorizontalOptions="Center"
                BackgroundColor="Blue"/>
    
        <!-- This have extra width because of AutomationProperties -->
        <Button Text="Tiny" 
                AutomationProperties.Name="Name"
                AutomationProperties.HelpText="Help Large Text "
                VerticalOptions="CenterAndExpand"
                HorizontalOptions="Center"
                BackgroundColor="Blue"/>

hartez · 2019-10-09T18:57:12Z

I wonder if this is showing up again because the fast renderers are the default now? Looks like Rui fixed this in the older LabelRenderer; maybe the same fix needs to be applied to the fast renderer: https://github.com/xamarin/Xamarin.Forms/pull/4433/files#diff-c754c889f501d0bbd657ea1ca0ad3370

MathewLC · 2019-10-09T18:58:26Z

I think it's the same @hartez !

MathewLC · 2019-10-09T19:05:45Z

I wonder if this is showing up again because the fast renderers are the default now? Looks like Rui fixed this in the older LabelRenderer; maybe the same fix needs to be applied to the fast renderer: https://github.com/xamarin/Xamarin.Forms/pull/4433/files#diff-c754c889f501d0bbd657ea1ca0ad3370

I can confirm that using the flag "UseLegacyRenderers", the UI show as expected!

jfversluis · 2019-10-10T06:28:07Z

Nice catch @hartez!

@magoolation this should be an easy fix then :) are you able to implement this anytime soon? Else to get this bug out of the way ASAP I can do it for you

magoolation · 2019-10-10T09:57:47Z

My plan is to do it next week as I’m attending to a conference until Sunday

…

On Thu, 10 Oct 2019 at 03:28 Gerald Versluis ***@***.***> wrote: Nice catch @hartez <https://github.com/hartez>! @magoolation <https://github.com/magoolation> this should be an easy fix then :) are you able to implement this anytime soon? Else to get this bug out of the way ASAP I can do it for you — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7875?email_source=notifications&email_token=AAEY5PGD7CT7VXSLNT56YX3QN3DRPA5CNFSM4I6SR7WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA26HQQ#issuecomment-540402626>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEY5PEREPTPSWB5CZ2D6I3QN3DRPANCNFSM4I6SR7WA> .

jfversluis · 2019-10-10T10:02:50Z

Awesome! Have a great conference and looking forward to your PR then

jfversluis · 2019-10-28T10:03:41Z

@magoolation Not trying to put pressure on you, sorry! But did you make any progress with this yet? Please let us know if you need help or want us to take over. Thanks!

magoolation · 2019-10-28T10:08:30Z

Thank you for asking. I couldn’t find a solution yet If you can give me a direction to follow i will aprecia-te it But if you think it will be easier solve it by yourself go ahead

…

On Mon, 28 Oct 2019 at 07:04 Gerald Versluis ***@***.***> wrote: @magoolation <https://github.com/magoolation> Not trying to put pressure on you, sorry! But did you make any progress with this yet? Please let us know if you need help or want us to take over. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7875?email_source=notifications&email_token=AAEY5PFLND4QFQEBSTN3NOTQQ22JFA5CNFSM4I6SR7WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECMKU4A#issuecomment-546876016>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEY5PABMZBWKQ7RM7AARS3QQ22JFANCNFSM4I6SR7WA> .

jfversluis · 2019-10-28T12:45:46Z

Did you see this comment from a little bit earlier? You can find it here: #7875 (comment)

Although I do see they are talking about a Label and not a Button there... So this code might be needed in the LabelRenderer in the FastRenderers folder but also on the button?

MathewLC · 2019-10-28T13:19:10Z

I didn't test the label. But I'm sure the button error was fixed in old render.
It seems like this is the right commit in which the fix was done:
ff13c49 @jfversluis @magoolation

Did you see this comment from a little bit earlier? You can find it here: #7875 (comment)

Although I do see they are talking about a Label and not a Button there... So this code might be needed in the LabelRenderer in the FastRenderers folder but also on the button?

jfversluis · 2019-10-28T13:39:39Z

Thanks @MathewLC !

Let me know if you can make any progress with this @magoolation. Else I will have a go at this to get this a11y bug out of the way!

magoolation · 2019-10-28T13:50:15Z

Thank you for the help. I'll give it a try tonight and let you know if I need something else. Em seg, 28 de out de 2019 às 09:46, Gerald Versluis < [email protected]> escreveu:

…

Did you see this comment from a little bit earlier? You can find it here: #7875 (comment) <#7875 (comment)> Although I do see they are talking about a Label and not a Button there... Maybe I need to do some more research myself :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7875?email_source=notifications&email_token=AAEY5PGUCXH6AD5IZNM5FUDQQ3NJDA5CNFSM4I6SR7WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECMXYXI#issuecomment-546929757>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEY5PD3WHF7RAZ5QDC2FFLQQ3NJDANCNFSM4I6SR7WA> .

czuck · 2019-11-21T22:17:30Z

I can confirm that this is happening with Labels as well. Here is my test code:

        <StackLayout
            VerticalOptions="FillAndExpand"
            Orientation="Vertical"
            BackgroundColor="Yellow"
            Spacing="10" >
            <Label x:Name="FirstLabel"
                Text="First Label"
                HorizontalOptions="Center"
                Font="12" 
                   BackgroundColor="Aqua"/>
            <Label x:Name="SecondLabel"
                Text="Second Label"
                HorizontalOptions="Center"
                Font="12" 
                   BackgroundColor="BlueViolet"
            AutomationProperties.Name="This is a really long Automation Properties Name, It's so long it takes up two lines"/>
            <Label x:Name="ThirdLabel"
                Text="Third Label"
                HorizontalOptions="Center"
                Font="12" 
                   BackgroundColor="ForestGreen"/>
            <Label x:Name="FourthLabel"
                Text="Fourth Label"
                HorizontalOptions="Center"
                Font="12" 
                   BackgroundColor="HotPink"
                   AutomationProperties.Name="Short Name"/>
        </StackLayout>

        public MainPage()
        {
            InitializeComponent();
            AutomationProperties.SetName(FirstLabel, "This is a really long Automation Properties Name, It's so long it takes up two lines");
            AutomationProperties.SetName(ThirdLabel, "Short Name");
        }

MathewLC · 2019-11-25T11:10:18Z

@czuck I think you can wait and see if the pull request that reference this bug fix it in the next version of xamarin forms(4.4.0). If not you can open another Issue and reference this.

czuck · 2019-12-09T17:01:44Z

Labels are working properly with 4.4.0-pre3! Thanks!

jfversluis · 2019-12-09T18:24:39Z

Thanks for letting us know @czuck ! @MathewLC can you confirm and update this issue appropriately?

MathewLC · 2019-12-13T17:10:05Z

@jfversluis I tested with the last release version of forms and in fact labels are working but buttons aren't. You guys didn't merge this yet, am I right?

jfversluis · 2019-12-14T09:00:46Z

Whoops, no the PR is still open and I see it was just waiting for my review 😱 sorry about that! I'll see to it that I do that ASAP. Thanks for the ping @MathewLC !

…ties (#8368) * Tryed to reproduce the same correction applied to the default implementation * Added repro sample * Fixed build error on iOS

samhouts · 2019-12-17T20:33:09Z

closed by #8368

MathewLC added s/unverified New report that has yet to be verified t/bug 🐛 labels Oct 8, 2019

MathewLC mentioned this issue Oct 8, 2019

AutomationProperties.Name on Button is visible on Android #4053

Closed

jfversluis added a/a11y 🔍 p/Android labels Oct 8, 2019

jfversluis removed the s/unverified New report that has yet to be verified label Oct 8, 2019

jfversluis self-assigned this Oct 8, 2019

MathewLC changed the title ~~[Bug] AutomationProperties on Button still visible on Android if Text Propertie is empty~~ [Bug] AutomationProperties on Button still visible on Android if Text Property is empty Oct 9, 2019

magoolation mentioned this issue Nov 4, 2019

#7875: Android: Button size changes when setting Accessibility properties #8368

Merged

2 tasks

samhouts added the in-progress This issue has an associated pull request that may resolve it! label Nov 5, 2019

jfversluis pushed a commit that referenced this issue Dec 17, 2019

#7875: Android: Button size changes when setting Accessibility proper…

24bb5bb

…ties (#8368) * Tryed to reproduce the same correction applied to the default implementation * Added repro sample * Fixed build error on iOS

samhouts closed this as completed Dec 17, 2019

holecekp mentioned this issue Jan 25, 2020

[Bug] Label displays an incorrect text when AutomationProperties.Name was set #9321

Closed

czuck mentioned this issue May 15, 2020

[Bug] Visible size of Datepicker UI is expanding if AutomationProperties are set. #10720

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug] AutomationProperties on Button still visible on Android if Text Property is empty #7875

[Bug] AutomationProperties on Button still visible on Android if Text Property is empty #7875

MathewLC commented Oct 8, 2019

jfversluis commented Oct 8, 2019

magoolation commented Oct 8, 2019

jfversluis commented Oct 8, 2019

MathewLC commented Oct 9, 2019 •

edited

Loading

jfversluis commented Oct 9, 2019

hartez commented Oct 9, 2019

MathewLC commented Oct 9, 2019

hartez commented Oct 9, 2019

MathewLC commented Oct 9, 2019

MathewLC commented Oct 9, 2019 •

edited

Loading

jfversluis commented Oct 10, 2019

magoolation commented Oct 10, 2019 via email

jfversluis commented Oct 10, 2019

jfversluis commented Oct 28, 2019

magoolation commented Oct 28, 2019 via email

jfversluis commented Oct 28, 2019 •

edited

Loading

MathewLC commented Oct 28, 2019

jfversluis commented Oct 28, 2019

magoolation commented Oct 28, 2019 via email

czuck commented Nov 21, 2019

MathewLC commented Nov 25, 2019

czuck commented Dec 9, 2019

jfversluis commented Dec 9, 2019

MathewLC commented Dec 13, 2019

jfversluis commented Dec 14, 2019

samhouts commented Dec 17, 2019

[Bug] AutomationProperties on Button still visible on Android if Text Property is empty #7875

[Bug] AutomationProperties on Button still visible on Android if Text Property is empty #7875

Comments

MathewLC commented Oct 8, 2019

Description

Basic Information

Screenshots

Reproduction Link

jfversluis commented Oct 8, 2019

magoolation commented Oct 8, 2019

jfversluis commented Oct 8, 2019

MathewLC commented Oct 9, 2019 • edited Loading

ScreenShot

Reproduction Link

jfversluis commented Oct 9, 2019

hartez commented Oct 9, 2019

MathewLC commented Oct 9, 2019

hartez commented Oct 9, 2019

MathewLC commented Oct 9, 2019

MathewLC commented Oct 9, 2019 • edited Loading

jfversluis commented Oct 10, 2019

magoolation commented Oct 10, 2019 via email

jfversluis commented Oct 10, 2019

jfversluis commented Oct 28, 2019

magoolation commented Oct 28, 2019 via email

jfversluis commented Oct 28, 2019 • edited Loading

MathewLC commented Oct 28, 2019

jfversluis commented Oct 28, 2019

magoolation commented Oct 28, 2019 via email

czuck commented Nov 21, 2019

MathewLC commented Nov 25, 2019

czuck commented Dec 9, 2019

jfversluis commented Dec 9, 2019

MathewLC commented Dec 13, 2019

jfversluis commented Dec 14, 2019

samhouts commented Dec 17, 2019

MathewLC commented Oct 9, 2019 •

edited

Loading

MathewLC commented Oct 9, 2019 •

edited

Loading

jfversluis commented Oct 28, 2019 •

edited

Loading