This repository was archived by the owner on May 1, 2024. It is now read-only.
[Android] Fix Label size when using Hint text #4433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When setting the
HelpText
for accessibility on aLabel
it causes to set theHint
text on aTextView
.Later when we are Measuring it Android will take the Hint text size in account and return wrong sizes that won't fit just the text but hint also.
We need to clear the Hint before measure.
Trying to move the calls to set hint to other places is no good because sizing is called sometimes multiple times when text is changing.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
Labels with HelpText with size correctly
Before/After Screenshots
BEFORE:

AFTER:

Testing Procedure
Go to issue 2580 make sure the 2 rows look the same.
PR Checklist