[REVERTED] [Android] Fix BottomNavigationItemView issue with MasterDetailPage

[kvpt]

Description of Change

On certains conditions MasterDetailPage can be in conflict with BottomNavigationView.
Like this :

The issue disappear if the BottomNavigationItem id are correctly set.
The BottomNavigationItem id was 0, 1, 2 ... which seem to cause issue with the ViewPager because these id are already used is others views in Android.

I tried to make an UI test case based on the reproduction in #9143, and you know what, impossible to reproduce in the UI test app. The problem seem to only occur during the app start.

Issues Resolved

• fixes (but reverted) Android: Master Navigation page displayed as third bottom tabbar item #9143

API Changes

None

Platforms Affected

• Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Use reproduction in #9143

PR Checklist

• Targets the correct branch
• Tests are passing (or failures are unrelated)

[jsuarezruiz]

@kvpt The fix makes sense to me. However, it would be great if we could add a repro sample to validate it in Core Gallery. I downloaded the repro sample from #9143 but there must be an error since it is an App using the empty project template.

The structure that causes the error is:

MainPage = MasterDetailPage:

Master: a Navigation page with a single Content page
Detail: a Tabbed page with 5 tabs:
--- each tab is a Navigation page with a single Content page in it
Toolbar placement is set to Bottom for Android.

Right?.

[kvpt]

@jsuarezruiz The code of the reproduction is in the App.xaml.cs.
I tried to move it in a TestCase, but the issue doesn't appear there.
I don't really understand why it cause a problem with this reproduction and not in the others cases.

[jsuarezruiz]

@kvpt Could you attach the repro sample again?. I would like to add a test to validate the issue. I have looked at #9143 but the App.xaml.cs in the attached repro sample is empty.

[kvpt]

@jsuarezruiz
It's really strange, I re-checked it and the App.xaml.cs code is present for me.
I copied it in a gist : https://gist.github.com/kvpt/0e8b099773e3c89e933c09518ef013cf

[jsuarezruiz]

I added a repro sample, although I can't reproduce the issue in Core Gallery.

[PureWeen]

It seems like this doesn't reproduce because the ID overlap happens here

Xamarin.Forms/Xamarin.Forms.Platform.Android/AppCompat/MasterDetailContainer.cs

Line 27 in 7a52542

Id = Platform.GenerateViewId();

Once you're in the context of the gallery the generated ids aren't at a value that will overlap any menu items