This repository was archived by the owner on May 1, 2024. It is now read-only.
Remove RadioButton.ButtonSource API #9967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
blocker
jfversluis
added
the
API-change
StephaneDelcroix
approved these changes
Mar 20, 2020
PureWeen
reviewed
Mar 21, 2020
| set { SetValue(ButtonSourceProperty, value); } | ||
| } | ||
| // TODO Needs implementations beyond Android | ||
| //public ImageSource ButtonSource |
There was a problem hiding this comment.
what happens right now if people use ImageSource?
There was a problem hiding this comment.
It’s kind of a funny API anyway. You’re able to set a custom image for the checkbox, but you need it together with the VSM to dynamically set the checked state. See the example in the gallery I commented out.
If people use it on platforms where it’s not implemented, nothing happens right now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Removes the
RadioButton.ButtonSourceAPI for now.This functionality was only implemented on Android and needs implementation on iOS, UWP and MacOS.
Issues Resolved
API Changes
Removed:
public static readonly BindableProperty ButtonSourcePropertypublic ImageSource ButtonSource { get; set; }Platforms Affected
Behavioral/Visual Changes
Android users on the 4.6-pre1 version will lose the ability to use a custom image for the radiobutton. When already in use, there will be a compilation error since the API has been removed.
Before/After Screenshots
Not applicable
Testing Procedure
N/A
PR Checklist