-
Notifications
You must be signed in to change notification settings - Fork 463
Base implementations for SemanticEffect and SemanticOrderView #1240
Conversation
Hey friends! How are we looking with this one? Just checking to see if you didn't accidentally forgot to flip it to "Ready for review" |
doesn't make a big difference on Android, but the property worsens accessibility on iOS
…rin/XamarinCommunityToolkit into accessibility-views-effects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's READYYY! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey friends, thanks for this really awesome! I have some comments and a question related to the video below.
When I access the effect page and turn on the ScreenReader everything works as expected, but when I go to the SemanticPage the SecreenReader breaks, as you can see there is no blue rectangle in the selected element and to make it return I need to block the screen and wait for a while. I believe that is a bug.
a11y_broken.mp4
src/CommunityToolkit/Xamarin.CommunityToolkit/Effects/Semantic/SemanticEffectRouter.android.cs
Outdated
Show resolved
Hide resolved
thanks for the review @pictos! I incorporated your feedback and fixed the code :) As for the potential bug you described - were you able to repro it on a physical device? I tried but wasn't able to repro it / think it might potentially be an emulator issue and therefore not a bug |
Another thing I'd like to highlight is that in general Forms is buggy with screen readers That's one reason we had to add this workaround Once we can merge this PR into 5.0 A lot of behavior should smooth out once that flag is enabled |
Hi everyone, thank you so much for adding these great accessibility APIs, I wish they were available in the documentation including how to use IA11yService. |
I will be working on the docs soon. Be sure to checkout https://channel9.msdn.com/Shows/XamarinShow/Improving-Accessibility-with-Xamarin-Community-Toolkit |
Thank you very much @rachelkang @PureWeen @jamesmontemagno @jfversluis, I love that they take accessibility as a priority. |
Description of Change
Implements SemanticEffect and SemanticOrderView based on @PureWeen's repo
Bugs Fixed
API Changes
Added:
Behavioral Changes
PR Checklist
approved