Skip to content

parse_units instead of parse_expression #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 1, 2020
Merged

parse_units instead of parse_expression #41

merged 7 commits into from
Nov 1, 2020

Conversation

TomNicholas
Copy link
Member

Fix for #40

keewis
keewis reviewed Nov 1, 2020
View reviewed changes
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @TomNicholas, looks good to me

keewis
keewis approved these changes Nov 1, 2020
View reviewed changes
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, and the CI passes. Let's merge?

@keewis keewis merged commit 62c15c5 into master Nov 1, 2020
@keewis keewis deleted the parse_units branch November 1, 2020 15:27
@keewis
Copy link
Collaborator

keewis commented Nov 1, 2020

this is a side effect of transferring the repository, but I think it might be best for you to also create a fork: it's much more difficult to accidentally push to master or other special branches. Additionally, people won't copy your feature branches when forking.

@TomNicholas
Copy link
Member Author

@keewis good point - I'll do that now

@keewis keewis linked an issue Nov 1, 2020 that may be closed by this pull request
parse_units instead of parse_expression #40
Closed
@keewis keewis mentioned this pull request Nov 2, 2020
Merged
2 tasks
@keewis keewis mentioned this pull request Apr 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keewis keewis keewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parse_units instead of parse_expression
2 participants
@TomNicholas @keewis